Patterns: Update pattern editing button labels #73195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 2.41 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Nov 12, 2025
Contributor
jasmussen
left a comment
There was a problem hiding this comment.
Let's try this. The term "Lock" feels too close to the actual locking feature, and also doesn't fully capture that the pattern remains a pattern even after editing the insides.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
reviewed
Nov 13, 2025
Comment on lines
+59
to
+60
| ? __( 'Exit pattern' ) | ||
| : __( 'Edit pattern' ) } |
Member
There was a problem hiding this comment.
Thanks for this PR!
Following on from this conversation, are there any alternatives?
I don't have any strong opinions on this, and would be happy just to get the change in to get it in front of eyeballs.
I think "Edit contents" was described as too generic. I remember "Edit design" floating about. "Edit section" was the suggestion on the other PR.
Contributor
There was a problem hiding this comment.
I still like Edit contents, specifically because it's simple and basic. Edit design feels misleading since much of that happens through layout tools in the inspector.
I do like the throughline of all this, that we are being careful to consider patterns, synced patterns, and template parts as having the same basic behaviors, even eventually extending that to the focused editing mode. For me it's also helpful to think of this as a visual block builder: those features allow you to build bigger blocks from smaller blocks, that have various ways of being reused, but they are all fundamentally the same.
Edit contents works for all of those, specifically because it's generic. I don't recall why we changed away from that, besides the "generic" aspect, there could be nuance that I'm missing. That's also why I approved this one as is, because we should probably not be using the locking terminology.
Contributor
Author
There was a problem hiding this comment.
I think the problem with "Edit contents" is that it's very similar to "Edit content". The idea of this work is to make it possible to edit the "content" without surfacing the design controls. So the point is, I can already edit the "content" of the pattern without clicking on this button. This button allows me to edit the design of the pattern and the inner blocks which are "contained" within the block - the "contents", but for me "content" and "contents" and just too similar to not cause a lot of confusion.
Contributor
Author
|
Let's bring this is and see how it feels. We can easily change it again... |
Member
Great call! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the content-only section editing button labels from "Lock design" / "Unlock design" to "Exit pattern" / "Edit pattern" for improved clarity and consistency with pattern editing terminology.
Taken out of #72574
Why?
The previous labels "Lock/Unlock design" were ambiguous and had some overlap with other unrelated concepts. The new labels "Edit pattern" and "Exit pattern" are more descriptive and align better with the actual functionality.
How?
Text changes
Testing Instructions
Screenshots or screencast