Skip to content

Patterns: Update pattern editing button labels #73195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

Patterns: Update pattern editing button labels #73195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/block-inspector/edit-contents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export default function EditContents( { clientId } ) {
} }
>
{ editedContentOnlySection
? __( 'Lock design' )
: __( 'Unlock design' ) }
? __( 'Exit pattern' )
: __( 'Edit pattern' ) }
Comment on lines +59 to +60
Copy link
Member

@ramonjd ramonjd Nov 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Following on from this conversation, are there any alternatives?

I don't have any strong opinions on this, and would be happy just to get the change in to get it in front of eyeballs.

I think "Edit contents" was described as too generic. I remember "Edit design" floating about. "Edit section" was the suggestion on the other PR.

Copy link
Contributor

@jasmussen jasmussen Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still like Edit contents, specifically because it's simple and basic. Edit design feels misleading since much of that happens through layout tools in the inspector.

I do like the throughline of all this, that we are being careful to consider patterns, synced patterns, and template parts as having the same basic behaviors, even eventually extending that to the focused editing mode. For me it's also helpful to think of this as a visual block builder: those features allow you to build bigger blocks from smaller blocks, that have various ways of being reused, but they are all fundamentally the same.

Edit contents works for all of those, specifically because it's generic. I don't recall why we changed away from that, besides the "generic" aspect, there could be nuance that I'm missing. That's also why I approved this one as is, because we should probably not be using the locking terminology.

Copy link
Contributor Author

@scruffian scruffian Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem with "Edit contents" is that it's very similar to "Edit content". The idea of this work is to make it possible to edit the "content" without surfacing the design controls. So the point is, I can already edit the "content" of the pattern without clicking on this button. This button allows me to edit the design of the pattern and the inner blocks which are "contained" within the block - the "contents", but for me "content" and "contents" and just too similar to not cause a lot of confusion.

</Button>
</VStack>
);
Expand Down
Loading