Patterns: Add edit section to the list view instead of Ungroup #73199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +166 B (+0.01%) Total Size: 2.42 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Nov 12, 2025
Comment on lines
41
to
47
| } = select( blockEditorStore ); | ||
| const { isSectionBlock: _isSectionBlock } = unlock( | ||
| select( blockEditorStore ) | ||
| ); |
Member
There was a problem hiding this comment.
Nit: You can access private and non-private selectors for same select.
ramonjd
reviewed
Nov 12, 2025
| onClose(); | ||
| } } | ||
| > | ||
| { _x( 'Edit pattern', 'Editing a pattern block in the Editor' ) } |
Member
There was a problem hiding this comment.
I like the updated copy.
@andrewserong raised an interesting point - are we referring to everything as patterns? E.g., template parts and templateLock: 'contentOnly'?
I'm fine with that by the way. 😄
Contributor
There was a problem hiding this comment.
I'm thinking that for new users who may not know what a pattern is, it might be more clear to say "edit section", plus that includes patterns, template parts etc..
Contributor
Author
There was a problem hiding this comment.
Updated to edit section...
| ! ( | ||
| isSectionBlock && window?.__experimentalContentOnlyPatternInsertion | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
Once we merge #73183 we won't need this. It's simpler to ensure that section blocks are never ungroupable, because there aren't any circumstances under which we'd want to ungroup them.
Contributor
Author
There was a problem hiding this comment.
Yeah this all got removed in the rebase.
821468b to
b38fcf4
Compare
Contributor
Author
|
I think this is ready for another review. |
a493fff to
034d174
Compare
ramonjd
approved these changes
Nov 14, 2025
Member
ramonjd
left a comment
There was a problem hiding this comment.
LGTM I checked on selected single and multiple patterns.
"Edit section" is consistent.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
From #72574
If a pattern is a section block then rather than offering an "Ungroup" option we should offer "Edit section".
Why?
This connects block actions in the List View to the contentOnly editing work for patterns.
How?
Creates a new hook to share the selectors between the new menu item and the "edit contents" button.
Testing Instructions
contentOnlyexperimentScreenshots or screencast