Fetch default branch for GitHub packages #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Jan 10, 2022
Comment on lines
+1411
to
+1416
| "Couldn't fetch default branch for package '%s' (HTTP code %d). Presuming default branch is 'master'.", | ||
| $package_name, | ||
| $response->status_code | ||
| ) | ||
| ); | ||
| return 'master'; |
Member
There was a problem hiding this comment.
AFAIK nowadays the default branch for new repositories on GitHub is main, but I suppose that it might still be master for older ones that haven't switched.
Member
Author
There was a problem hiding this comment.
Yes, I'm keeping the master for now as GitHub and Composer seem to keep aliases around for BC. This can still be changed at a later date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to the
wp package installcommand so that it tries to retrieve the default branch of a GitHub repository if no version was provided, instead of using the hard-codedmasterbranch as a default.