Merge pull request #146 from wp-cli/fix/fetch-default-branch-for-github

Fetch default branch for GitHub packages

Author: schlessera

composer.json

@@ -22,7 +22,10 @@
     },
     "config": {
         "process-timeout": 7200,
-        "sort-packages": true
+        "sort-packages": true,
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        }
     },
     "extra": {
         "branch-alias": {

features/package-install.feature

@@ -96,7 +96,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall yoast/wp-cli-faker`
     Then STDOUT should contain:
       """
-      Removing require statement
+      Removing require statement for package 'yoast/wp-cli-faker' from
       """
     And STDOUT should contain:
       """
@@ -137,7 +137,7 @@ Feature: Install WP-CLI packages
       """
 
     When I try `wp package install git@github.com:wp-cli.git`
-    Then STDERR should be:
+    Then STDERR should contain:
       """
       Error: Couldn't parse package name from expected path '<name>/<package>'.
       """
@@ -176,7 +176,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli/google-sitemap-generator-cli`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli/google-sitemap-generator-cli' from
       """
     Then STDOUT should contain:
       """
@@ -310,7 +310,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli-test/github-test-command`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli-test/github-test-command' from
       """
     And STDOUT should contain:
       """
@@ -361,7 +361,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli-test/github-test-command`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli-test/github-test-command' from
       """
     And STDOUT should contain:
       """
@@ -419,7 +419,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli-test/github-test-command`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli-test/github-test-command' from
       """
     And STDOUT should contain:
       """
@@ -470,7 +470,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli-test/github-test-command`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli-test/github-test-command' from
       """
     And STDOUT should contain:
       """
@@ -521,7 +521,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli-test/github-test-command`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli-test/github-test-command' from
       """
     And STDOUT should contain:
       """
@@ -539,9 +539,12 @@ Feature: Install WP-CLI packages
     Given an empty directory
 
     # Install and uninstall with case-sensitive name
-    When I run `wp package install GeekPress/wp-rocket-cli`
-    Then STDERR should be empty
-    And STDOUT should match /Installing package (?:GeekPress|geekpress)\/wp-rocket-cli \(dev-master\)/
+    When I try `wp package install GeekPress/wp-rocket-cli`
+    Then STDERR should contain:
+      """
+      Warning: Package name mismatch...Updating from git name 'GeekPress/wp-rocket-cli' to composer.json name 'wp-media/wp-rocket-cli'.
+      """
+    And STDOUT should match /Installing package wp-media\/wp-rocket-cli \(dev-trunk\)/
     # This path is sometimes changed on Macs to prefix with /private
     And STDOUT should contain:
       """
@@ -555,28 +558,32 @@ Feature: Install WP-CLI packages
       """
       Success: Package installed.
       """
-    And the contents of the {PACKAGE_PATH}composer.json file should match /("?:GeekPress|geekpress)\/wp-rocket-cli"/
+    And the contents of the {PACKAGE_PATH}composer.json file should match /"wp-media\/wp-rocket-cli"/
 
     When I run `wp package list --fields=name`
     Then STDOUT should be a table containing rows:
-      | name                    |
-      | GeekPress/wp-rocket-cli |
+      | name                   |
+      | wp-media/wp-rocket-cli |
 
     When I run `wp help rocket`
     Then STDOUT should contain:
       """
       wp rocket
       """
 
-    When I run `wp package uninstall GeekPress/wp-rocket-cli`
+    When I try `wp package uninstall GeekPress/wp-rocket-cli`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-media/wp-rocket-cli' from
       """
     And STDOUT should contain:
       """
       Success: Uninstalled package.
       """
+    And STDERR should contain:
+      """
+      Warning: Package name mismatch...Updating from git name 'GeekPress/wp-rocket-cli' to composer.json name 'wp-media/wp-rocket-cli'.
+      """
     And the {PACKAGE_PATH}composer.json file should not contain:
       """
       rocket
@@ -604,7 +611,7 @@ Feature: Install WP-CLI packages
     When I run `wp package list --fields=name`
     Then STDOUT should be a table containing rows:
       | name                    |
-      | GeekPress/wp-rocket-cli |
+      | geekpress/wp-rocket-cli |
 
     When I run `wp help rocket`
     Then STDOUT should contain:
@@ -615,7 +622,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall geekpress/wp-rocket-cli`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'geekpress/wp-rocket-cli' from
       """
     And STDOUT should contain:
       """
@@ -718,7 +725,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli/google-sitemap-generator-cli`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli/google-sitemap-generator-cli' from
       """
     And STDOUT should contain:
       """
@@ -782,7 +789,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall capitalwpcli/examplecommand`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'capitalwpcli/examplecommand' from
       """
     And STDOUT should contain:
       """
@@ -837,7 +844,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli/google-sitemap-generator-cli`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli/google-sitemap-generator-cli' from
       """
     And STDOUT should contain:
       """
@@ -925,7 +932,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli/community-command`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli/community-command' from
       """
     And STDOUT should contain:
       """
@@ -1004,7 +1011,7 @@ Feature: Install WP-CLI packages
     When I run `wp package uninstall wp-cli/community-command`
     Then STDOUT should contain:
       """
-      Removing require statement from
+      Removing require statement for package 'wp-cli/community-command' from
       """
     And STDOUT should contain:
       """

features/package.feature

@@ -6,16 +6,20 @@ Feature: Manage WP-CLI packages
     When I run `wp package browse`
     Then STDOUT should contain:
       """
-      danielbachhuber/wp-cli-reset-post-date-command
+      runcommand/hook
       """
 
-    When I run `wp package install danielbachhuber/wp-cli-reset-post-date-command`
+    When I run `wp package install runcommand/hook`
     Then STDERR should be empty
 
-    When I run `wp help reset-post-date`
+    When I run `wp help hook`
     Then STDERR should be empty
+    And STDOUT should contain:
+      """
+      List callbacks registered to a given action or filter.
+      """
 
-    When I try `wp --skip-packages --debug help reset-post-date`
+    When I try `wp --skip-packages --debug help hook`
     Then STDERR should contain:
       """
       Debug (bootstrap): Skipped loading packages.
@@ -28,16 +32,16 @@ Feature: Manage WP-CLI packages
     When I run `wp package list`
     Then STDOUT should contain:
       """
-      danielbachhuber/wp-cli-reset-post-date-command
+      runcommand/hook
       """
 
-    When I run `wp package uninstall danielbachhuber/wp-cli-reset-post-date-command`
+    When I run `wp package uninstall runcommand/hook`
     Then STDERR should be empty
 
     When I run `wp package list`
     Then STDOUT should not contain:
       """
-      danielbachhuber/wp-cli-reset-post-date-command
+      runcommand/hook
       """
 
   Scenario: Run package commands early, before any bad code can break them
@@ -60,20 +64,20 @@ Feature: Manage WP-CLI packages
   @require-php-7.2 @broken
   Scenario: Revert the WP-CLI packages composer.json when fail to install/uninstall a package due to memory limit
     Given an empty directory
-    When I try `{INVOKE_WP_CLI_WITH_PHP_ARGS--dmemory_limit=10M -ddisable_functions=ini_set} package install danielbachhuber/wp-cli-reset-post-date-command`
+    When I try `{INVOKE_WP_CLI_WITH_PHP_ARGS--dmemory_limit=10M -ddisable_functions=ini_set} package install runcommand/hook`
     Then the return code should not be 0
     And STDERR should contain:
       """
       Reverted composer.json.
       """
 
-    When I run `wp package install danielbachhuber/wp-cli-reset-post-date-command`
+    When I run `wp package install runcommand/hook`
     Then STDOUT should contain:
       """
       Success: Package installed.
       """
 
-    When I try `{INVOKE_WP_CLI_WITH_PHP_ARGS--dmemory_limit=10M -ddisable_functions=ini_set} package uninstall danielbachhuber/wp-cli-reset-post-date-command`
+    When I try `{INVOKE_WP_CLI_WITH_PHP_ARGS--dmemory_limit=10M -ddisable_functions=ini_set} package uninstall runcommand/hook`
     Then the return code should not be 0
     And STDERR should contain:
       """
@@ -85,7 +89,7 @@ Feature: Manage WP-CLI packages
     Then the {RUN_DIR}/mypackages/composer.json file should exist
     And save the {RUN_DIR}/mypackages/composer.json file as {MYPACKAGES_COMPOSER_JSON}
 
-    When I try `WP_CLI_PACKAGES_DIR={RUN_DIR}/mypackages {INVOKE_WP_CLI_WITH_PHP_ARGS--dmemory_limit=10M -ddisable_functions=ini_set} package install danielbachhuber/wp-cli-reset-post-date-command`
+    When I try `WP_CLI_PACKAGES_DIR={RUN_DIR}/mypackages {INVOKE_WP_CLI_WITH_PHP_ARGS--dmemory_limit=10M -ddisable_functions=ini_set} package install runcommand/hook`
     Then the return code should not be 0
     And STDERR should contain:
       """
@@ -118,7 +122,7 @@ Feature: Manage WP-CLI packages
       """
     And STDOUT should be empty
 
-    When I try `WP_CLI_PACKAGES_DIR={RUN_DIR}/packages-bad-json wp package install danielbachhuber/wp-cli-reset-post-date-command`
+    When I try `WP_CLI_PACKAGES_DIR={RUN_DIR}/packages-bad-json wp package install runcommand/hook`
     Then the return code should be 1
     And STDERR should contain:
       """
@@ -162,7 +166,7 @@ Feature: Manage WP-CLI packages
       """
     And save the {RUN_DIR}/packages-no-such-package/composer.json file as {NO_SUCH_PACKAGE_COMPOSER_JSON}
 
-    When I try `WP_CLI_PACKAGES_DIR={RUN_DIR}/packages-no-such-package wp package install danielbachhuber/wp-cli-reset-post-date-command`
+    When I try `WP_CLI_PACKAGES_DIR={RUN_DIR}/packages-no-such-package wp package install runcommand/hook`
     Then the return code should be 1
     And STDERR should contain:
       """