-
Notifications
You must be signed in to change notification settings - Fork 370
[Storage] Fix fileExists() to return true for directories #2968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+202
−6
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Storage] Fix fileExists() to return true for directories
The fileExists() method in InMemoryFilesystemBackend and OpfsFilesystemBackend
was incorrectly returning false for directories, only checking for files.
This caused the Blueprint Editor to crash when loading blueprints with
bundled resources at the root level (e.g., ./piel.zip), because the code
tried to mkdir('/') after fileExists('/') returned false.
This change makes fileExists() behave as a general "path exists" check,
returning true for both files and directories. The root directory now
correctly returns true as well.
Also adds comprehensive unit tests for InMemoryFilesystemBackend to
document and verify the expected filesystem semantics.- Loading branch information
commit b86f265a20f6260eb5846b74bbac49469a8e5fd2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll adjust it in a follow up PR to require an explicit
recursiveoption