[Storage] Fix fileExists() to return true for directories #2968
+202
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fileExists() method in InMemoryFilesystemBackend and OpfsFilesystemBackend
was incorrectly returning false for directories, only checking for files.
This caused the Blueprint Editor to crash when loading blueprints with
bundled resources at the root level (e.g., ./piel.zip), because the code
tried to mkdir('/') after fileExists('/') returned false.
This change makes fileExists() behave as a general "path exists" check,
returning true for both files and directories. The root directory now
correctly returns true as well.
Also adds comprehensive unit tests for InMemoryFilesystemBackend to
document and verify the expected filesystem semantics.
adamziel
commented
Nov 30, 2025
| }); | ||
|
|
||
| it('should return true for nested directories', async () => { | ||
| await backend.mkdir('/parent/child'); |
Collaborator
Author
There was a problem hiding this comment.
I'll adjust it in a follow up PR to require an explicit recursive option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Blueprint Editor was crashing when loading blueprints via URL that have bundled resources at the root level (e.g.,
./piel.zip→/piel.zip). The root cause was thatfileExists()in bothInMemoryFilesystemBackendandOpfsFilesystemBackendonly returnedtruefor files, not directories.When the code tried to check if the parent directory
/exists before creating it,fileExists('/')incorrectly returnedfalse, causing the code to attemptmkdir('/')which threw "Invalid path: /".This PR fixes
fileExists()to behave as a general "path exists" check, returningtruefor both files and directories. The root directory now correctly returnstrueas well.Test plan
InMemoryFilesystemBackendcoveringfileExists,isDir,mkdir,writeFile,read,listFiles,unlink,rmdir,mv, andclearfileExists('/')returnstruefileExists()returnstruefor directories