Skip to content

Fix: Condition is not strictly checked on options-general.php file #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+96 −3
Open

Fix: Condition is not strictly checked on options-general.php file #6965

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5b7aa
fix: strict comparison in options-general.php
snehapatil2001 Jul 3, 2024
6428ee9
chore: add corresponding unit tests.
snehapatil2001 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: strict comparison in options-general.php
  • Loading branch information
@snehapatil2001
snehapatil2001 committed Jul 3, 2024
commit 5d5b7aa652b1b8770cd9acbba6f3b46bd07701d2
8 changes: 5 additions & 3 deletions src/wp-admin/options-general.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,12 +354,14 @@ class="<?php echo esc_attr( $classes_for_button ); ?>"

if ( empty( $tzstring ) ) { // Create a UTC+- zone if no timezone string exists.
$check_zone_info = false;
if ( 0 === (int) $current_offset ) {
if ( 0 === $current_offset || '0' === $current_offset ) {
$tzstring = 'UTC+0';
} elseif ( $current_offset < 0 ) {
} elseif ( ( is_numeric( $current_offset ) && (float) $current_offset < 0 ) ) {
$tzstring = 'UTC' . $current_offset;
} else {
} elseif ( is_numeric( $current_offset ) ) {
$tzstring = 'UTC+' . $current_offset;
} else {
$tzstring = 'UTC+0';
}
}

Expand Down