Skip to content

Conversation

@snehapatil2001
Copy link

@snehapatil2001 snehapatil2001 commented Jul 3, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/57030

Description

  • Fixes a strict comparison issue in options-general.php where the $current_offset variable was not being strictly compared as an integer.
  • This issue could lead to unexpected behavior when comparing the gmt_offset option, especially when it could be interpreted as different types such as string or float.

Changes Made

  • Adjusted the comparison of $current_offset to ensure it is strictly compared as an integer 0.
  • Updated logic to handle cases where gmt_offset may vary in type (integer, string, or float).
  • Introduced unit tests to validate the behavior across different gmt_offset scenarios.

Added Unit Tests

  • Created gmtOffset.php file to house unit tests specifically targeting the gmt_offset behavior.
  • Covered scenarios such as integer 0, string '0', negative float values, and invalid string inputs for gmt_offset.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jul 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props snehapatil02.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jul 3, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant