Add name to wp_register_webfonts
#46404
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Solves #46398
Adds support for
nameattribute inwp_register_webfonts:Why?
I'm describing use case in detail at #46398, but essentially to match how
theme.jsonalready works.How?
Allows passing
nameattribute as part of font family array.I'm not entirely happy with solution as conceptually "Name" would belong to higher up, not necessarily inside font-family definition. I also didn't see better alternative.
Testing Instructions
Add this to mu-plugins or elsewhere:
Open site editor and note font families:
Testing Instructions for Keyboard
Screenshots or screencast