Skip to content

Conversation

@simison
Copy link
Member

@simison simison commented Dec 5, 2022

See p9Jlb4-5Dj-p2 for design discussion.

Adding new fonts for better i18n

Related to #27441

image

Changes proposed in this Pull Request:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

@simison simison added [Focus] i18n Internationalization / i18n, adaptation to different languages [Package] Google Fonts Provider This package no longer exists in the monorepo. [Feature] Google Fonts labels Dec 5, 2022
@simison simison changed the title Update/fonts i18n Add fonts for better i18n Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/fonts-i18n to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: January 3, 2023.
  • Scheduled code freeze: December 26, 2022.

@simison
Copy link
Member Author

simison commented Dec 8, 2022

In google these fonts have rather unclear names:

  • Alexandria
  • IBM Plex Sans Arabic
  • Noto Sans Hebrew
  • Noto Sans HK
  • Noto Sans JP
  • Noto Sans KR
  • Noto Sans SC
  • Noto Sans TC
  • Noto Sans Telugu
  • Noto Serif Hebrew
  • Noto Serif HK
  • Noto Serif JP
  • Noto Serif KR
  • Noto Serif SC
  • Noto Serif TC

That's not great for customers.

Few options to move forward, in order of preference

  1. Add support for a separate name attribute in Gutenberg: PRed. Edit: API is frozen for the time being.
  2. Filter Theme.json with wp_theme_json_data_theme and inject corrected name — tested, works but a bit dirty. PR: Add new i18n fonts and rename them via filter #27854
  3. Just have fonts with unclear names like "Noto Sans JS"

I'll see how adding the support goes, and then add filtering instead.

@simison simison closed this Dec 27, 2022
@simison simison deleted the update/fonts-i18n branch December 27, 2022 12:52
@simison
Copy link
Member Author

simison commented Dec 27, 2022

Implemented via filters in #27854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Google Fonts [Focus] i18n Internationalization / i18n, adaptation to different languages [Package] Google Fonts Provider This package no longer exists in the monorepo. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants