Skip to content

Add ability to pass extensions to make-json command #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2025
Merged

Add ability to pass extensions to make-json command #439

merged 4 commits into from
Apr 25, 2025

Conversation

@michaelw85
Copy link
Contributor

@michaelw85 michaelw85 commented Apr 25, 2025

Resolves #231

@michaelw85 michaelw85 requested a review from a team as a code owner April 25, 2025 11:42
@codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@michaelw85 michaelw85 mentioned this pull request Apr 25, 2025
Closed
@swissspidy
Copy link
Member

swissspidy commented Apr 25, 2025

Thanks for opening this PR, appreciate the initiative!

Please note that most tests here are Behat tests instead of PHPUnit tests, see features/makejson.feature. We should follow that in this PR.

@swissspidy swissspidy changed the title Add ability to pass extensions to make json command Add ability to pass extensions to make-json command Apr 25, 2025
@michaelw85
Copy link
Contributor Author

michaelw85 commented Apr 25, 2025

Thanks for opening this PR, appreciate the initiative!

Please note that most tests here are Behat tests instead of PHPUnit tests, see features/makejson.feature. We should follow that in this PR.

Alright, I thought it would be pretty easy to unit test (did struggle a bit with mocking though 😅 ) I will have a look at the Behat tests and add some.

@michaelw85
Copy link
Contributor Author

michaelw85 commented Apr 25, 2025

@swissspidy I've added some basic scenarios similar to the unit tests and everything passes 🥳

swissspidy
swissspidy reviewed Apr 25, 2025
View reviewed changes
swissspidy
swissspidy requested changes Apr 25, 2025
View reviewed changes
@michaelw85
Copy link
Contributor Author

michaelw85 commented Apr 25, 2025

@swissspidy I've updated the PR, resolved your feedback. Removed files and the new unit tests in favor of Behat tests, and lastly improved removing .min from minified files. Let me know if you see anything else that needs improvement.

@michaelw85 michaelw85 requested a review from swissspidy April 25, 2025 18:52
@swissspidy swissspidy added this to the 2.6.5 milestone Apr 25, 2025
@swissspidy swissspidy merged commit 5d79390 into wp-cli:main Apr 25, 2025
52 checks passed
@michaelw85 michaelw85 deleted the #231_add_custom_extension_support branch April 28, 2025 06:37
@michaelw85 michaelw85 mentioned this pull request Nov 6, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

command:i18n-make-json

Projects

None yet

Milestone

2.6.5

Development

Successfully merging this pull request may close these issues.

Search for translation sources with custom extensions via make-json

2 participants

@michaelw85 @swissspidy