[Feature] make-pot: Add extensions flag

[michaelw85]

Feature Request

• Yes, I reviewed the contribution guidelines.

Describe your use case and the problem you are facing

A while back support was added to pass extensions to the make-json command: #439 but the make-pot still has hardcoded extensions for JS extraction. https://github.com/wp-cli/i18n-command/blob/main/src/MakePotCommand.php#L672

Describe the solution you'd like

I want to be able to pass the TS extension to make-pot. A current workaround is to include a dist folder, but of course, it would be much nicer to have references to the actual code in the resulting pot file.

[swissspidy]

That would require use to support parsing TypeScript in PHP, which AFAIK isn't possible today. There is no such library capable of doing that. The library we use is strictly for ECMAScript (JS). That works for us because make-pot is primarily used for running against already built JS files in WordPress projects.

If you want to extract strings from a TS codebase, I recommend using a different tool for that and then merging results with the ones from make-pot if needed.

[michaelw85]

That would require use to support parsing TypeScript in PHP, which AFAIK isn't possible today. There is no such library capable of doing that. The library we use is strictly for ECMAScript (JS). That works for us because make-pot is primarily used for running against already built JS files in WordPress projects.

If you want to extract strings from a TS codebase, I recommend using a different tool for that and then merging results with the ones from make-pot if needed.

I was looking at the code, and thought it only did a readfile and scans plain text, but I just found the function scanner 🙈
Since this isn't a simple request, which I thought it was, I will close it.