Fix: Condition is not strictly checked on options-general.php file #6965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57030
Description
options-general.phpwhere the$current_offsetvariable was not being strictly compared as an integer.gmt_offsetoption, especially when it could be interpreted as different types such as string or float.Changes Made
$current_offsetto ensure it is strictly compared as an integer0.gmt_offsetmay vary in type (integer, string, or float).gmt_offsetscenarios.Added Unit Tests
gmtOffset.phpfile to house unit tests specifically targeting thegmt_offsetbehavior.0, string'0', negative float values, and invalid string inputs forgmt_offset.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.