Perf: Try pure function version of useBlockDisplayInformation and useBlockDisplayTitle #73095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplayTitle Seeing if using a pure function version of these in components that already have a useSelect will help improve performance. The list view is especially heavy on this, so combining selectors there can have a compounding effect.
|
Size Change: +443 B (+0.02%) Total Size: 2.47 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 694159e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19174648627
|
Member
|
What do you think about introducing new private selectors for block icon and title. I had a proposal while ago, but closed it since didn't had time to work on it and wasn't expected significant perf improvements - #73095. |
Contributor
Author
|
I'm not opposed. I think there should be some refactoring done, as there are scattered usages of useBlockDisplayInfo that only use the icon and title. And even some that do useBlockDisplayInfo to get the icon and useBlockDisplayTitle to get the title. I don't expect much perf improvement either, but the code for titles is especially confusing, and I feel like it shouldn't be :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Seeing if using a pure function version of these in components that already have a useSelect will help improve performance. The list view is especially heavy on this, so combining selectors there can have a compounding effect.
Also, adds a new performance test for typing with the list view open on a page with many blocks. This should stress test the system more. I'd like it to be obvious when there's a new useSelect added that is not performant.
Why?
Perf.
How?
Extract the guts of the hooks and export those as a function as well. That way, if you have an existing useSelect, you don't have to add a new one in order to use the function.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast