Skip to content

Perf: Try pure function version of useBlockDisplayInformation and useBlockDisplayTitle #73095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

Perf: Try pure function version of useBlockDisplayInformation and useBlockDisplayTitle #73095

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2093f4
Try pure function version of useBlockDisplayInformation and useBlockD…
jeryj Nov 7, 2025
694159e
Add a list view typing test to catch perfromance regressions
jeryj Nov 7, 2025
6fafa62
Only return information needed from useSelect
jeryj Nov 7, 2025
4f4a0c0
Fix truncating
jeryj Nov 7, 2025
f93c8f2
Fix regressions
jeryj Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix regressions
  • Loading branch information
@jeryj
jeryj committed Nov 7, 2025
commit f93c8f24e709dc929375784b2fd1ac6c88d6a7a7
4 changes: 4 additions & 0 deletions packages/block-editor/src/components/block-toolbar/test/block-toolbar-icon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ describe( 'BlockToolbarIcon', () => {
icon: paragraph,
showIconLabels: false,
variant: 'default',
blockTitle: 'Block Name',
} ) );

render( <BlockToolbarIcon { ...defaultProps } /> );
Expand All @@ -126,6 +127,7 @@ describe( 'BlockToolbarIcon', () => {
icon: paragraph,
showIconLabels: false,
variant: 'default',
blockTitle: 'Block Name',
} ) );

render(
Expand All @@ -150,6 +152,7 @@ describe( 'BlockToolbarIcon', () => {
icon: paragraph,
showIconLabels: false,
variant: 'default',
blockTitle: 'Block Name',
} ) );

render( <BlockToolbarIcon { ...defaultProps } /> );
Expand All @@ -163,6 +166,7 @@ describe( 'BlockToolbarIcon', () => {
icon: paragraph,
showIconLabels: false,
variant: 'default',
blockTitle: 'Block Name',
} ) );

render(
Expand Down
6 changes: 5 additions & 1 deletion packages/block-editor/src/components/list-view/block-select-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { hasBlockSupport } from '@wordpress/blocks';
*/
import BlockIcon from '../block-icon';
import { getBlockDisplayInformation } from '../use-block-display-information';
import { getBlockDisplayTitle } from '../block-title/use-block-display-title';
import ListViewExpander from './expander';
import { useBlockLock } from '../block-lock';
import useListViewImages from './use-list-view-images';
Expand Down Expand Up @@ -79,7 +80,10 @@ function ListViewBlockSelectButton(
select( blockEditorStore ).getBlockEditingMode(
clientId
) === 'contentOnly',
blockTitle: blockInformation?.title,
blockTitle: getBlockDisplayTitle( select, {
clientId,
context: 'list-view',
} ),
icon: blockInformation?.icon,
anchor: blockInformation?.anchor,
isSticky: blockInformation?.positionType === 'sticky',
Expand Down
6 changes: 5 additions & 1 deletion packages/block-editor/src/components/list-view/drop-indicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { useSelect } from '@wordpress/data';
*/
import BlockIcon from '../block-icon';
import { getBlockDisplayInformation } from '../use-block-display-information';
import { getBlockDisplayTitle } from '../block-title/use-block-display-title';
import ListViewExpander from './expander';

export default function ListViewDropIndicatorPreview( {
Expand All @@ -37,7 +38,10 @@ export default function ListViewDropIndicatorPreview( {
} );

return {
blockTitle: blockInformation?.title,
blockTitle: getBlockDisplayTitle( select, {
clientId: draggedBlockClientId,
context: 'list-view',
} ),
blockIcon: blockInformation?.icon,
};
},
Expand Down
Loading