Skip to content

Correct plugin main file in bootstrap in scaffolded test #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2024
Merged

Correct plugin main file in bootstrap in scaffolded test #335

merged 2 commits into from
Apr 26, 2024

Conversation

@ernilambar
Copy link
Member

@ernilambar ernilambar commented Apr 17, 2024

Fixes #190

  • Use correct plugin main file in tests/bootstrap.php for in scaffolded tests
  • Fallback name will be same as of now plugin-slug.php
  • Feature test is also added

@ernilambar ernilambar marked this pull request as ready for review April 17, 2024 06:50
@ernilambar ernilambar requested a review from a team as a code owner April 17, 2024 06:50
swissspidy
swissspidy approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there was an easier way to get the main file from a slug, but apparently not

@swissspidy swissspidy added this to the 2.3.0 milestone Apr 26, 2024
@swissspidy swissspidy merged commit 7a7d145 into wp-cli:main Apr 26, 2024
@swissspidy
Copy link
Member

swissspidy commented Apr 26, 2024

wp-cli/wp-cli#5935

@ernilambar ernilambar deleted the 190-plugin-bootstrap branch August 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

command:scaffold-plugin-tests

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

Scaffolding plugin tests manually loads wrong file

2 participants

@ernilambar @swissspidy