Skip to content

Fix testing on WP trunk #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 13, 2021
Merged

Fix testing on WP trunk #297

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6d73d4e
Remove outdated TODO
schlessera Aug 13, 2021
9f63e52
Forward PHPUnit Polyfills path constant to bootstrap file
schlessera Aug 13, 2021
fea4ec8
Allow for tests to run on PHP 8+
schlessera Aug 13, 2021
5b2bf64
Remove test destinction between PHP <8 and >=8
schlessera Aug 13, 2021
4950563
Adapt error message to expect for WP Core < 5.9
schlessera Aug 13, 2021
5563dd9
Adapt theme tests to include separate test install
schlessera Aug 13, 2021
d5342ed
Fix alignment
schlessera Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow for tests to run on PHP 8+
  • Loading branch information
@schlessera
schlessera committed Aug 13, 2021
commit fea4ec830c6fb1a36971f242f34c626eb4a74a8d
5 changes: 0 additions & 5 deletions templates/plugin-bootstrap.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@
* @package {{plugin_package}}
*/

if ( PHP_MAJOR_VERSION >= 8 ) {
echo "The scaffolded tests cannot currently be run on PHP 8.0+. See https://github.com/wp-cli/scaffold-command/issues/285" . PHP_EOL; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
exit( 1 );
}

$_tests_dir = getenv( 'WP_TESTS_DIR' );

if ( ! $_tests_dir ) {
Expand Down