Skip to content

Improve Warning Message in wp rewrite flush #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Improve Warning Message in wp rewrite flush #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions features/rewrite.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,14 @@ Feature: Manage WordPress rewrites
When I try `wp --skip-plugins rewrite flush`
Then STDERR should contain:
"""
Warning: Some rewrite rules may be missing because plugins weren't loaded.
Warning: Some rewrite rules may be missing because plugins weren't loaded by WP-CLI.
"""
And the return code should be 0

When I try `wp --skip-plugins --skip-themes rewrite flush`
Then STDERR should contain:
"""
Warning: Some rewrite rules may be missing because plugins and themes weren't loaded.
Warning: Some rewrite rules may be missing because plugins and themes weren't loaded by WP-CLI.
"""
And the return code should be 0

Expand Down
2 changes: 1 addition & 1 deletion src/Rewrite_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@
return;
}
$skipped = implode( ' and ', $skipped );
WP_CLI::warning( sprintf( "Some rewrite rules may be missing because %s weren't loaded.", $skipped ) );
WP_CLI::warning( sprintf( "Some rewrite rules may be missing because %s weren't loaded by WP-CLI.", $skipped ) );

Check warning on line 362 in src/Rewrite_Command.php

View check run for this annotation

Codecov / codecov/patch

src/Rewrite_Command.php#L362 

Added line #L362 was not covered by tests
}
}

Expand Down