Skip to content

Add deprecation hint in wp language core activate's docblock #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2023
Merged

Add deprecation hint in wp language core activate's docblock #125

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
913f7cd
refactor: adds deprecation hint in 'wp language core activate' docblock
Pathan-Amaankhan Aug 27, 2023
c444b12
refactor: updates deprication message
Pathan-Amaankhan Aug 27, 2023
eeb97ff
Couple more tweaks
danielbachhuber Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: adds deprecation hint in 'wp language core activate' docblock
  • Loading branch information
@Pathan-Amaankhan
Pathan-Amaankhan committed Aug 27, 2023
commit 913f7cdc7e56438c43b33103c6a8ae1f10c8ecfa
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ wp language core

### wp language core activate

Activates a given language.
Activates a given language. (Deprecated: use wp site switch-language instead)

~~~
wp language core activate <language>
Expand Down
2 changes: 1 addition & 1 deletion src/Core_Language_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ public function update( $args, $assoc_args ) { // phpcs:ignore Generic.CodeAnaly
}

/**
* Activates a given language.
* Activates a given language. (Deprecated: use wp site switch-language instead)
Copy link
Member

@danielbachhuber danielbachhuber Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this on a new line, and make it similar to the deprecation notice for wp scaffold block? https://github.com/wp-cli/scaffold-command/blob/594f0b47a2af6a19664f0f4717998b2cf5cb3ed7/src/Scaffold_Command.php#L205-L208

Copy link
Contributor Author

@Pathan-Amaankhan Pathan-Amaankhan Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! On it 👍.

Copy link
Contributor Author

@Pathan-Amaankhan Pathan-Amaankhan Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @danielbachhuber,
Have updated the doc-comment as suggested.

Please do let me know if further changes are required 😃.

cc: @swissspidy

Copy link
Member

@danielbachhuber danielbachhuber Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pathan-Amaankhan Thanks! I made one more minor tweak eeb97ff

*
* ## OPTIONS
*
Expand Down