Skip to content

Translate "description" field from theme.json #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Translate "description" field from theme.json #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add new field "description" to theme.json top level to translate 
Add expectation to existing behat tests
  • Loading branch information
@ramonjd
ramonjd committed Jul 1, 2024
commit 5fdacfd22250601e39de63a2fcedffd55e3e21eb
1 change: 1 addition & 0 deletions assets/theme-i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"title": "Style variation name",
"description": "Style variation description",
"settings": {
"typography": {
"fontSizes": [
Expand Down
6 changes: 6 additions & 0 deletions features/makepot.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3658,6 +3658,7 @@ Feature: Generate a POT file of a WordPress project
{
"version": "1",
"title": "My style variation",
"description": "My style variation description",
"settings": {
"color": {
"duotone": [
Expand Down Expand Up @@ -3716,6 +3717,11 @@ Feature: Generate a POT file of a WordPress project
msgctxt "Style variation name"
msgid "My style variation"
"""
And the foo-theme/foo-theme.pot file should contain:
"""
msgctxt "Style variation description"
msgid "My style variation description"
"""

Scenario: Extract strings from the blocks section of theme.json files
Given an empty foo-theme directory
Expand Down