Skip to content

Add wp i18n make-php command #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 30, 2024
Merged

Add wp i18n make-php command #363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9b2c119
Add make-php skeleton
swissspidy May 5, 2023
aefd457
Set certain headers
swissspidy May 6, 2023
96e6a96
Fix tests
swissspidy May 8, 2023
9e88ac7
No else
swissspidy May 10, 2023
d3f06fa
Merge branch 'main' into add/try-make-php
swissspidy Oct 3, 2023
804c005
Update code & tests
swissspidy Oct 3, 2023
48e08ae
Lint fixes
swissspidy Oct 3, 2023
b7c57fe
Merge branch 'main' into add/try-make-php
swissspidy Nov 9, 2023
f0ce86a
Merge branch 'main' into add/try-make-php
swissspidy Nov 29, 2023
594a91c
Apply suggestions from code review
swissspidy Nov 29, 2023
f071aba
Add back dirname
swissspidy Nov 29, 2023
28e85d9
Update file extension
swissspidy Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@swissspidy
swissspidy committed Nov 29, 2023
commit 594a91c5902a34723c3852f383ffc3b5c53d090c
2 changes: 1 addition & 1 deletion features/makejson.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Feature: Split PO files into JSON files.
When I try `wp i18n make-json foo`
Then STDERR should contain:
"""
Error: Source file or directory does not exist!
Error: Source file or directory does not exist.
"""
And the return code should be 1

Expand Down
4 changes: 2 additions & 2 deletions features/makemo.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Feature: Generate MO files from PO files
When I try `wp i18n make-mo foo`
Then STDERR should contain:
"""
Error: Source file or directory does not exist!
Error: Source file or directory does not exist.
"""
And the return code should be 1
Scenario: Bail for destination being a file when source is a folder
Expand All @@ -18,7 +18,7 @@ Feature: Generate MO files from PO files
When I try `wp i18n make-mo foo test.mo `
Then STDERR should contain:
"""
Error: Destination file not supported when source is a directory!
Error: Destination file not supported when source is a directory.
"""
And the return code should be 1
Scenario: Uses source folder as destination by default
Expand Down
2 changes: 1 addition & 1 deletion features/makephp.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Feature: Generate PHP files from PO files
When I try `wp i18n make-php foo`
Then STDERR should contain:
"""
Error: Source file or directory does not exist!
Error: Source file or directory does not exist.
"""
And the return code should be 1

Expand Down
Loading