Skip to content

Support requires and requires_php in plugin/theme list and update command #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 18, 2025
Merged

Support requires and requires_php in plugin/theme list and update command #440

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
730da5d
Support requires and requires_php in plugin/theme list and update com…
mrsdizzie Dec 22, 2024
f2153c8
Fix phpcs
mrsdizzie Dec 24, 2024
91f68a7
Adjust warning text
mrsdizzie Dec 27, 2024
0cd790d
Update test requirements to match moina minimum WordPress version
mrsdizzie Dec 29, 2024
e4d0dd9
Use a specific elseif to avoid errors in logic
mrsdizzie Feb 13, 2025
a4021e2
Use new HTTP mock feature to more reliably test
mrsdizzie Feb 13, 2025
351a2ec
Require wp 4.0 for plugins update test
mrsdizzie Feb 14, 2025
130dcd6
Use twentythirteen for this test
mrsdizzie Feb 14, 2025
1f9609c
use --force
mrsdizzie Feb 14, 2025
36ec8f6
Update test to work across any WordPress version
mrsdizzie Feb 14, 2025
38409d0
More changes for PHP 5.6 / WP 3.7 tests to skip or pass
mrsdizzie Feb 18, 2025
47b062e
Revert use of twentyten
mrsdizzie Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use new HTTP mock feature to more reliably test
  • Loading branch information
@mrsdizzie
mrsdizzie committed Feb 13, 2025
commit a4021e2ff346887824b8a0aad5d3c4af5e115f14
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"wp-cli/entity-command": "^1.3 || ^2",
"wp-cli/language-command": "^2.0",
"wp-cli/scaffold-command": "^1.2 || ^2",
"wp-cli/wp-cli-tests": "^4"
"wp-cli/wp-cli-tests": "^4.3.7"
},
"config": {
"process-timeout": 7200,
Expand Down
102 changes: 70 additions & 32 deletions features/plugin.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,57 +811,95 @@ Feature: Manage WordPress plugins
5.5
"""

@require-php-7
Scenario: Show plugin update as unavailable if it doesn't meet WordPress requirements
Given a WP install

When I run `wp core download --version=6.4 --force`
And I run `rm -r wp-content/themes/*`
And I run `wp plugin install wp-super-cache --version=1.9.4`

When I run `wp plugin list --name=wp-super-cache --field=update_version`
And save STDOUT as {UPDATE_VERSION}

When I run `wp plugin list --name=wp-super-cache --field=requires`
And save STDOUT as {REQUIRES}

When I run `wp plugin list --name=wp-super-cache --field=requires_php`
And save STDOUT as {REQUIRES_PHP}
And a wp-content/plugins/example/example.php file:
"""
<?php
/**
* Plugin Name: Example Plugin
* Version: 1.0.0
* Requires at least: 3.7
* Tested up to: 6.7
"""

Given that HTTP requests to https://api.wordpress.org/plugins/update-check/1.1/ will respond with:
"""
HTTP/1.1 200 OK

{
"plugins": [],
"translations": [],
"no_update": {
"example/example.php": {
"id": "w.org/plugins/example",
"slug": "example",
"plugin": "example/example.php",
"new_version": "2.0.0",

"requires": "100",
"requires_php": "7.2",
"requires_plugins": [],
"compatibility": []
}
}
}
"""

And I run `wp plugin list`
Then STDOUT should be a table containing rows:
| name | status | update | version | update_version | auto_update | requires | requires_php |
| wp-super-cache | inactive | unavailable | 1.9.4 | {UPDATE_VERSION} | off | {REQUIRES} | {REQUIRES_PHP} |
| example | inactive | unavailable | 1.0.0 | 2.0.0 | off | 100 | 7.2 |

When I try `wp plugin update wp-super-cache`
When I try `wp plugin update example`
Then STDERR should contain:
"""
Warning: wp-super-cache: This update requires WordPress version
Warning: example: This update requires WordPress version 100
"""

@less-than-php-8.0 @require-wp-5.6
Scenario: Show plugin update as unavailable if it doesn't meet PHP requirements
Scenario: Show plugin update as unavailable if it doesn't meet PHP requirements
Given a WP install
And a wp-content/plugins/example/example.php file:
"""
<?php
/**
* Plugin Name: Example Plugin
* Version: 1.0.0
* Requires at least: 3.7
* Tested up to: 6.7
"""

And I run `wp plugin install edit-flow --version=0.9.8`

When I run `wp plugin list --name=edit-flow --field=update_version`
And save STDOUT as {UPDATE_VERSION}

When I run `wp plugin list --name=edit-flow --field=requires`
And save STDOUT as {REQUIRES}

When I run `wp plugin list --name=edit-flow --field=requires_php`
And save STDOUT as {REQUIRES_PHP}
Given that HTTP requests to https://api.wordpress.org/plugins/update-check/1.1/ will respond with:
"""
HTTP/1.1 200 OK

{
"plugins": {
"example/example.php": {
"id": "w.org/plugins/example",
"slug": "example",
"plugin": "example/example.php",
"new_version": "2.0.0",
"requires": "3.7",
"tested": "6.6",
"requires_php": "100",
"requires_plugins": [],
"compatibility": []
}
},
"translations": [],
"no_update": []
}
"""

And I run `wp plugin list`
Then STDOUT should be a table containing rows:
| name | status | update | version | update_version | auto_update | requires | requires_php |
| edit-flow | inactive | unavailable | 0.9.8 | {UPDATE_VERSION} | off | {REQUIRES} | {REQUIRES_PHP} |
| example | inactive | unavailable | 1.0.0 | 2.0.0 | off | 3.7 | 100 |

When I try `wp plugin update edit-flow`
When I try `wp plugin update example`
Then STDERR should contain:
"""
Warning: edit-flow: This update requires PHP version
Warning: example: This update requires PHP version 100
"""

87 changes: 74 additions & 13 deletions features/theme.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,27 +624,88 @@ Feature: Manage WordPress themes
@require-php-7
Scenario: Show theme update as unavailable if it doesn't meet WordPress requirements
Given a WP install
And a wp-content/themes/example/style.css file:
"""
/*
Theme Name: example
Version: 1.0.0
*/
"""
And a wp-content/themes/example/index.php file:
"""
<?php
// Silence is golden.
"""

When I run `wp core download --version=6.2 --force`
And I run `rm -r wp-content/themes/*`
And I run `wp theme install kadence --version=1.1.1`
Given that HTTP requests to https://api.wordpress.org/themes/update-check/1.1/ will respond with:
"""
HTTP/1.1 200 OK

When I run `wp theme list --name=kadence --field=update_version`
And save STDOUT as {UPDATE_VERSION}
{
"themes": {
"example": {
"theme": "example",
"new_version": "2.0.0",
"requires": "100",
"requires_php": "5.6"
}
},
"translations": [],
"no_update": []
}
"""

When I run `wp theme list --name=kadence --field=requires`
And save STDOUT as {REQUIRES}
And I run `wp theme list`
Then STDOUT should be a table containing rows:
| name | status | update | version | update_version | auto_update | requires | requires_php |
| example | inactive | unavailable | 1.0.0 | 2.0.0 | off | 100 | 5.6 |

When I try `wp theme update example`
Then STDERR should contain:
"""
Warning: example: This update requires WordPress version 100
"""

Scenario: Show theme update as unavailable if it doesn't meet PHP requirements
Given a WP install
And a wp-content/themes/example/style.css file:
"""
/*
Theme Name: example
Version: 1.0.0
*/
"""
And a wp-content/themes/example/index.php file:
"""
<?php
// Silence is golden.
"""

Given that HTTP requests to https://api.wordpress.org/themes/update-check/1.1/ will respond with:
"""
HTTP/1.1 200 OK

When I run `wp theme list --name=kadence --field=requires_php`
And save STDOUT as {REQUIRES_PHP}
{
"themes": {
"example": {
"theme": "example",
"new_version": "2.0.0",
"requires": "3.7",
"requires_php": "100"
}
},
"translations": [],
"no_update": []
}
"""

And I run `wp theme list`
Then STDOUT should be a table containing rows:
| name | status | update | version | update_version | auto_update | requires | requires_php |
| kadence | inactive | unavailable | 1.1.1 | {UPDATE_VERSION} | off | {REQUIRES} | {REQUIRES_PHP} |
| name | status | update | version | update_version | auto_update | requires | requires_php |
| example | inactive | unavailable | 1.0.0 | 2.0.0 | off | 3.7 | 100 |

When I try `wp theme update kadence`
When I try `wp theme update example`
Then STDERR should contain:
"""
Warning: kadence: This update requires WordPress version
Warning: example: This update requires PHP version 100
"""
Loading