Skip to content

Check WordPress and PHP requirements before installing a theme or plugin #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Check WordPress and PHP requirements before installing a theme or plugin #436

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d75ff32
Check WordPress and PHP requirements before installing a theme or plugin
mrsdizzie Dec 6, 2024
e522b03
Use version_compare directly
mrsdizzie Dec 6, 2024
c9852ac
Only use major wp version in version_compare
mrsdizzie Dec 7, 2024
e64abdc
Adjust test requirements
mrsdizzie Dec 7, 2024
fcae1a0
Require PHP 7 for tests installing WP 6.4
swissspidy Dec 11, 2024
99c7380
Add new --ignore-requirements arg
mrsdizzie Dec 12, 2024
11afbb3
Update tests
swissspidy Dec 13, 2024
c6ca68b
Use `get_flag_value`
swissspidy Dec 13, 2024
713f7bb
Move to elseif
swissspidy Dec 13, 2024
8d9edf4
Ignore requirements in test
swissspidy Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use version_compare directly 
The built in wp functions for this are too new (Added in 5.2)
  • Loading branch information
@mrsdizzie
mrsdizzie committed Dec 6, 2024
commit e522b030ad17f25fcb9f86e21df50e504cb1723b
5 changes: 3 additions & 2 deletions src/Plugin_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ public function path( $args, $assoc_args ) {
}

protected function install_from_repo( $slug, $assoc_args ) {
global $wp_version;
$api = plugins_api( 'plugin_information', array( 'slug' => $slug ) );

if ( is_wp_error( $api ) ) {
Expand All @@ -594,8 +595,8 @@ protected function install_from_repo( $slug, $assoc_args ) {
$requires_php = isset( $api->requires_php ) ? $api->requires_php : null;
$requires_wp = isset( $api->requires ) ? $api->requires : null;

$compatible_php = is_php_version_compatible( $requires_php );
$compatible_wp = is_wp_version_compatible( $requires_wp );
$compatible_php = empty( $requires_php ) || version_compare( PHP_VERSION, $requires_php, '>=' );
$compatible_wp = empty( $requires_wp ) || version_compare( $wp_version, $requires_wp, '>=' );

if ( ! $compatible_wp ) {
return new WP_Error( 'requirements_not_met', "This plugin does not work with your version of WordPress. Minimum WordPress requirement is $requires_wp" );
Expand Down
5 changes: 3 additions & 2 deletions src/Theme_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ public function path( $args, $assoc_args ) {
}

protected function install_from_repo( $slug, $assoc_args ) {
global $wp_version;
$api = themes_api( 'theme_information', array( 'slug' => $slug ) );

if ( is_wp_error( $api ) ) {
Expand All @@ -407,8 +408,8 @@ protected function install_from_repo( $slug, $assoc_args ) {
$requires_php = isset( $api->requires_php ) ? $api->requires_php : null;
$requires_wp = isset( $api->requires ) ? $api->requires : null;

$compatible_php = is_php_version_compatible( $requires_php );
$compatible_wp = is_wp_version_compatible( $requires_wp );
$compatible_php = empty( $requires_php ) || version_compare( PHP_VERSION, $requires_php, '>=' );
$compatible_wp = empty( $requires_wp ) || version_compare( $wp_version, $requires_wp, '>=' );

if ( ! $compatible_wp ) {
return new WP_Error( 'requirements_not_met', "This theme does not work with your version of WordPress. Minimum WordPress requirement is $requires_wp" );
Expand Down
Loading