Skip to content

Update to WPCS v3 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Update to WPCS v3 #419

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b168e90
Update to wp-cli-tests v4 (which requires WPCS v3)
schlessera Aug 30, 2023
54e7389
Fix all autofixable CS issues
schlessera Aug 30, 2023
08bcc24
Address PHPCS warning
danielbachhuber Sep 1, 2023
f9c697c
Ignore a few deprecation notices
danielbachhuber Sep 1, 2023
b35ad87
Ignore a couple unused parameters
danielbachhuber Sep 1, 2023
671766b
Restore loose comparison to fix test failure
danielbachhuber Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore a couple unused parameters
  • Loading branch information
@danielbachhuber
danielbachhuber committed Sep 1, 2023
commit b35ad87f204a4ea10cfed8612bde2290a7fc04eb
4 changes: 2 additions & 2 deletions src/User_Application_Password_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ public function update( $args, $assoc_args ) {
* @param array $assoc_args Associative array of associative arguments.
* @throws ExitException If the application password could not be created.
*/
public function record_usage( $args, $assoc_args ) {
public function record_usage( $args, $assoc_args ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed
$args = $this->replace_login_with_user_id( $args );

list( $user_id, $uuid ) = $args;
Expand Down Expand Up @@ -497,7 +497,7 @@ public function delete( $args, $assoc_args ) {
* @param array $assoc_args Associative array of associative arguments.
* @throws ExitException If the application password could not be created.
*/
public function exists( $args, $assoc_args ) {
public function exists( $args, $assoc_args ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed
$args = $this->replace_login_with_user_id( $args );

list( $user_id, $app_name ) = $args;
Expand Down