Skip to content

Add Support for Retry in WP CLI Core Download Command #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+68 −14
Open

Add Support for Retry in WP CLI Core Download Command #258

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
161eb20
Add retry and retry-delay in core download cli
abhi3315 Apr 26, 2024
742714d
Exit early from the retry loop if the status is ok or 404
abhi3315 Apr 26, 2024
76c4f61
Fix phpcs code sniffing issue
abhi3315 Apr 26, 2024
dd81ca8
Add max retry to 5 and remove control of retry-delay
abhi3315 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix phpcs code sniffing issue
  • Loading branch information
@abhi3315
abhi3315 committed Apr 26, 2024
commit 76c4f61840942421ae02392e0982cd9e6f7e24ba
6 changes: 3 additions & 3 deletions src/Core_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ function () use ( $temp ) {
'insecure' => $insecure,
];

$retry = (int) Utils\get_flag_value( $assoc_args, 'retry', 0 );
$retry = (int) Utils\get_flag_value( $assoc_args, 'retry', 0 );
$retry_delay = (int) Utils\get_flag_value( $assoc_args, 'retry-delay', 5 );

do {
Expand Down Expand Up @@ -325,8 +325,8 @@ function () use ( $temp ) {
$retry = (int) Utils\get_flag_value( $assoc_args, 'retry', 0 );

do {
$md5_response = Utils\http_request( 'GET', $download_url . '.md5', null, [], $options );
$status_code = (int) $md5_response->status_code;
$md5_response = Utils\http_request( 'GET', $download_url . '.md5', null, [], $options );
$status_code = (int) $md5_response->status_code;
$is_response_ok = $status_code >= 200 && $status_code < 300;

// Exit the loop if the response is OK or the status code is 404.
Expand Down