Skip to content

Fix: Prevents invalid wp-config.php when passwords contain double quotes #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2025
Merged

Fix: Prevents invalid wp-config.php when passwords contain double quotes #203

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c71861
Fix: Prevents invalid wp-config.php when passwords contain double quotes
rollybueno Oct 15, 2025
900416b
Fix: Escape backslashes first before single quotes
rollybueno Oct 26, 2025
0b24d51
Test: Add teset scenario for password with double backslash
rollybueno Oct 28, 2025
b35b5cf
Fix: Failing test unit
rollybueno Oct 29, 2025
6415fe7
Test: Move into dedicated scenario since using --false key failed
rollybueno Oct 29, 2025
b17a5ad
Test: Remove --force flag for the new scenario
rollybueno Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix: Failing test unit
  • Loading branch information
@rollybueno
rollybueno committed Oct 29, 2025
commit b35b5cfcbb06f72f09d03b968c08ce20e880c7bf
12 changes: 6 additions & 6 deletions features/config-create.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,6 @@ Feature: Create a wp-config file
define( 'DB_HOST', 'localhost:{SOCKET}' );
"""

When I run `wp config create --skip-check --dbname=somedb --dbuser=someuser --dbpass='my\\password'`
Then the wp-config.php file should contain:
"""
define( 'DB_PASSWORD', 'my\\\\password' )
"""

@require-php-7.0
Scenario: Configure with salts generated
Given an empty directory
Expand Down Expand Up @@ -265,6 +259,12 @@ Feature: Create a wp-config file
p@(ss){w0r?d><}"!With"DoubleQuotes
"""

When I run `wp config create --skip-check --dbname=somedb --dbuser=someuser --dbpass='my\\password'` --force
Then the wp-config.php file should contain:
"""
define( 'DB_PASSWORD', 'my\\\\password' )
"""

@require-mysql @require-mysql-5.7
Scenario: Configure with required SSL connection
Given an empty directory
Expand Down
Loading