Skip to content

Suppress output of eval(get_wp_config_code) preventing errors printing twice #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Suppress output of eval(get_wp_config_code) preventing errors printing twice #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Suppress output of eval(get_wp_config_code) to prevent errors printin… 
…g twice
  • Loading branch information
@pwtyler
pwtyler committed Sep 17, 2024
commit cce428a724356422f9e9ded887076dcfc89dcc36
4 changes: 4 additions & 0 deletions src/Config_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,12 @@ private static function get_wp_config_vars( $wp_config_path = '' ) {
$wp_cli_original_defined_vars = get_defined_vars();
$wp_cli_original_includes = get_included_files();

// Output buffering prevents warnings or notices while parsing wp-config
// from printing twice. See https://github.com/wp-cli/wp-cli/issues/4944
ob_start();
// phpcs:ignore Squiz.PHP.Eval.Discouraged -- Don't have another way.
eval( WP_CLI::get_runner()->get_wp_config_code( $wp_config_path ) );
ob_end_clean();

$wp_config_vars = self::get_wp_config_diff( get_defined_vars(), $wp_cli_original_defined_vars, 'variable', [ 'wp_cli_original_defined_vars' ] );
$wp_config_constants = self::get_wp_config_diff( get_defined_constants(), $wp_cli_original_defined_constants, 'constant' );
Expand Down