Skip to content

Fix failing checksum tests due to timeout on WP_VERSION=trunk #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Fix failing checksum tests due to timeout on WP_VERSION=trunk #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88fc10c
Fix failing checksum tests due to timeout on `WP_VERSION=trunk`
danielbachhuber Feb 17, 2023
99ed1d8
Fail the test if `STDERR` isn't empty
danielbachhuber Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions features/checksum-core.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,15 @@ Feature: Validate checksums for WordPress install
"""

Scenario: Verify core checksums for a non US local
Given a WP install
# If current WP_VERSION is nightly, trunk or old then from checksum might not exist, so STDERR may or may not be empty.
And I try `wp core download --locale=en_GB --version=4.3.1 --force`
Given an empty directory
And I run `wp core download --locale=en_GB --version=4.3.1 --force`
Then STDOUT should contain:
"""
Success: WordPress downloaded.
"""
And the return code should be 0

# Similarly if current WP_VERSION is nightly, trunk or old then will get "File should not exist" warnings, so STDERR may or may not be empty.
When I try `wp core verify-checksums`
When I run `wp core verify-checksums`
Then STDOUT should be:
"""
Success: WordPress installation verifies against checksums.
Expand Down