Skip to content

Add --exclude argument for verifying checksums #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Add --exclude argument for verifying checksums #123

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e49d08f
feat: introduce exclude feature (WIP)
iDschepe Jun 13, 2024
fc021e0
chore: added negative test case
iDschepe Jun 13, 2024
5dbc550
fix: changed to comma separated, added readme
iDschepe Jun 13, 2024
19a6304
Merge branch 'main' into feat/checksum-exclude-files
swissspidy Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: added negative test case
  • Loading branch information
@iDschepe
iDschepe committed Jun 13, 2024
commit fc021e03fd0a783e9ab195a82d4ee09458df7641
21 changes: 16 additions & 5 deletions features/checksum-core.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,15 +231,11 @@ Feature: Validate checksums for WordPress install

Scenario: Verify core checksums with excluded files
Given a WP install
And "WordPress" replaced with "Wordpress" in the readme.html file
And "WordPress" replaced with "PressWord" in the readme.html file
And a wp-includes/some-filename.php file:
"""
sample content of some file
"""
And a readme.html file:
"""
# You really should read me
"""

When I try `wp core verify-checksums --exclude='readme.html wp-includes/some-filename.php'`
Then STDERR should be empty
Expand All @@ -249,3 +245,18 @@ Feature: Validate checksums for WordPress install
"""
And the return code should be 0

Scenario: Verify core checksums with missing one excluded file
Given a WP install
And "WordPress" replaced with "PressWord" in the readme.html file
And a wp-includes/some-filename.php file:
"""
sample content of some file
"""

When I try `wp core verify-checksums --exclude=' wp-includes/some-filename.php'`
Then STDERR should be:
"""
Warning: File doesn't verify against checksum: readme.html
Error: WordPress installation doesn't verify against checksums.
"""
And the return code should be 1