Skip to content

Conversation

@semseysandor
Copy link
Contributor

WpOrgApi::get_plugin_checksums() throws exception if failed to fetch checksums (e.g. network issues, wrong URL). In these cases at least a warning should be logged to add a hint about the error and save 90% of debug time.

@semseysandor semseysandor requested a review from a team as a code owner May 16, 2023 11:46
@danielbachhuber danielbachhuber added this to the 2.2.1 milestone May 17, 2023
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks!

@danielbachhuber danielbachhuber merged commit ac6b835 into wp-cli:main May 17, 2023
@semseysandor semseysandor deleted the warning-get-plugin-checksum branch May 17, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants