Persist blueprint bundle when saving temporary site to OPFS #2966
+245
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving a temporary site to OPFS, if the site has a blueprint bundle (originalBlueprint with filesystem methods), the entire bundle is now copied to a 'blueprint-bundle' subdirectory alongside the site data. This allows sites that were created from blueprint bundles (via 'Run Blueprint') to have their bundled resources preserved for future use. Changes: - Add opfs-blueprint-bundle-storage.ts with persistBlueprintBundle() and PersistedBlueprintBundle class for saving/loading bundles - Update persist-temporary-site.ts to check for bundle and persist it - Add 'bundle-directory' type to BlueprintSource - Update opfs-site-storage.ts to set originalBlueprintSource when bundle is persisted and load from bundle on site load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
When saving a temporary site to OPFS, stores the associated blueprint bundle into the OPFS alongside the site data. Right now, the bundled files are not preserved. It's not a big problem today, but the upcoming bundle editor (#2942) makes the problem much more prominent. Thus, let's solve it before making bundles more prominent.