-
Notifications
You must be signed in to change notification settings - Fork 3.2k
HTML API: Reduce skip_script_data length checks #9230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
sirreal
wants to merge
13
commits into
WordPress:trunk
from
sirreal:html-api/improve-skip-script-data-len-checks
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6ad9951
Move script data length checks to top of loop
sirreal b3b3177
Remove parser_state change in skip_script_data
sirreal ca16e0e
Remove more length checks
sirreal 0456be7
Improve documentation
sirreal ea6f7d3
Improve comment explaining early return logic
sirreal 4be62b9
Improve loop comment
sirreal df2affa
Add script tag processing tests
sirreal d0cbb00
Remove problematic tests
sirreal aaa6763
Reword explanatory comment.
dmsnell f7d4b8e
Move script parsing adjacent to other script parsing test
sirreal c3c76d6
Merge branch 'trunk' into html-api/improve-skip-script-data-len-checks
sirreal 34c3b28
Continue to tweak comment and improve examples
sirreal 325bcb8
Merge branch 'trunk' into html-api/improve-skip-script-data-len-checks
sirreal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove parser_state change in skip_script_data
The parser state is managed externally and should not be changed in skip_script_data
- Loading branch information
commit b3b3177e27ce1dfbc8c73c629392b7af6b6e3f1b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.