-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Tests: Add new assertEqualHTML assertion
#8882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 47 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
00617e7
Tests: Add assertEqualMarkup trait
ockham cbba80a
Add test coverage for assertion helper method
ockham 0602711
Fix include path
ockham c01a3c1
Remove now-obsolete method of the same name from Tests_Dependencies_S…
ockham 5a5b2b1
Remove obsolete require_lib
ockham 1cb1f23
Add since PHPDoc
ockham 38b575a
Move assertion to class WP_UnitTestCase_Base
ockham 8204474
Get rid of trait
ockham 03f7b09
WPCS
ockham 09cf449
Remove potentially obsolete PHPCS ignore
ockham b2fc3ff
Revert "Remove now-obsolete method of the same name from Tests_Depend…
ockham ef27f4f
Bring back assertEqualMarkup override, harmonize signature
ockham 51e4613
Remove trailing newline
ockham 2258487
Fix class name
ockham 5bfdf9b
Tweak tests
ockham 2b33187
Remove strict_types declaration
ockham 82d57b6
Fix heredoc indentation for PHP 7.2 compat :rolleyes:
ockham 3fbf857
Use WP_Block_Parser for block parsing
ockham 3090d65
Handle void blocks correctly
ockham 47dccc1
Rearrange logic
ockham bb2404b
Allow for different whitespace in class attribute
ockham 192009b
De-duplicate block class names
ockham 7cf7c64
Change Html5lib test format reference link
ockham d0d46fe
Add more PHPDoc and an example to build_tree_representation
ockham 252569d
Use Tag Processor to normalize block class names
ockham eae650f
Whitespace :rolleyes:
ockham e8ceff2
Rename function to build_equivalent_html_semantic_tree
ockham 5c44e1a
Add covers PHPDoc to tests
ockham 5ff8ad4
Fall back to DOM\HTMLDocument for PHP 8.4+
ockham 90f958d
Revert "Bring back assertEqualMarkup override, harmonize signature"
ockham 7735df4
Rename new method to assertEqualBlockMarkup
ockham 7581a94
Add @todo note to "old" assertEqualMarkup
ockham 8d7e402
Update PHPDoc for assertEqualBlockMarkup
ockham 51600e6
Add test with capitalization/lower case letters.
ockham ddaec5e
Update to use the new assertEqualMarkup helper
sirreal 98ad4c9
Rename test helper to assertEqualMarkup
sirreal 492316d
Fix script async/defer strategy expectation to match printed scripts
sirreal c7317e7
Add CDATA inline script wrappers where they appear in markup
sirreal 7472609
FIXME: Skip an inaccurate test
sirreal 844a076
Adjust expected output to use attributes as generated
sirreal 514967f
Add html5 support to a test that expects html5 support
sirreal fed7647
Script quotes in IE7 conditional _comments_ produce semantically _dif…
sirreal 28e1fd7
Revert irrelevant change
sirreal c2f1bfa
Fix more missing CDATA comments
sirreal 5a60a70
Remove scripts specific assertEqualMarkup implementation
sirreal b0df96a
Use more consistent code backticks in docblock
sirreal 1cb1daf
Fix phpcs issues
sirreal defbe92
Remove now-obsolete parse_markup_fragment() method
ockham 2b66454
Fix PHPDoc param order
ockham 95ddd9a
Tweak PHPDoc description of build_equivalent_semantic_tree
ockham 6a79216
Add return type, tweak PHPDoc
ockham 9469f43
Rename to build_visual_html_tree
ockham b07677e
Rename to assertEqualHTML
ockham f7736c4
Fix indentation
ockham a83ff2b
Add ticket annotations
ockham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
299 changes: 299 additions & 0 deletions
299
tests/phpunit/includes/build-equivalent-html-semantic-tree.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,299 @@ | ||
| <?php | ||
|
|
||
| /* phpcs:disable WordPress.Security.EscapeOutput.ExceptionNotEscaped */ | ||
|
|
||
| /** | ||
| * Generates the tree-like structure represented in the Html5lib tests. | ||
| * | ||
| * That format is extended with a special representation of block delimiters and their attributes. | ||
| * Furthermore, it the order of attributes and class names is normalized both for HTML tags and block delimiters, | ||
| * as is the whitespace in HTML tags' style attribute. | ||
| * | ||
| * For example, consider the following block markup: | ||
| * | ||
| * <!-- wp:separator {"className":"is-style-default has-custom-classname","style":{"spacing":{"margin":{"top":"50px","bottom":"50px"}}},"backgroundColor":"accent-1"} --> | ||
| * <hr class="wp-block-separator is-style-default has-custom-classname" style="margin-top: 50px; margin-bottom: 50px" /> | ||
| * <!-- /wp:separator --> | ||
| * | ||
| * This will be represented as: | ||
| * | ||
| * BLOCK["core/separator"] | ||
| * { | ||
| * "backgroundColor": "accent-1", | ||
| * "className": "has-custom-classname is-style-default", | ||
| * "style": { | ||
| * "spacing": { | ||
| * "margin": { | ||
| * "top": "50px", | ||
| * "bottom": "50px" | ||
| * } | ||
| * } | ||
| * } | ||
| * } | ||
| * <hr> | ||
| * class="has-custom-classname is-style-default wp-block-separator" | ||
| * style="margin-top:50px;margin-bottom:50px;" | ||
| * | ||
| * | ||
| * @see https://github.com/WordPress/wordpress-develop/blob/trunk/tests/phpunit/data/html5lib-tests/tree-construction/README.md | ||
| * | ||
| * @param string|null $fragment_context Context element in which to parse HTML, such as BODY or SVG. | ||
| * @param string $html Given test HTML. | ||
ockham marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * @return string|null Tree structure of parsed HTML, if supported, else null. | ||
| */ | ||
| function build_equivalent_html_semantic_tree( string $html, ?string $fragment_context ) { | ||
ockham marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
ockham marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| $processor = $fragment_context | ||
| ? WP_HTML_Processor::create_fragment( $html, $fragment_context ) | ||
| : WP_HTML_Processor::create_full_parser( $html ); | ||
| if ( null === $processor ) { | ||
| throw new Error( 'Could not create a parser.' ); | ||
| } | ||
| $tree_indent = ' '; | ||
|
|
||
| $output = ''; | ||
| $indent_level = 0; | ||
| $was_text = null; | ||
| $text_node = ''; | ||
|
|
||
| $block_context = array(); | ||
|
|
||
| while ( $processor->next_token() ) { | ||
| if ( null !== $processor->get_last_error() ) { | ||
| break; | ||
| } | ||
|
|
||
| $token_name = $processor->get_token_name(); | ||
| $token_type = $processor->get_token_type(); | ||
| $is_closer = $processor->is_tag_closer(); | ||
|
|
||
| if ( $was_text && '#text' !== $token_name ) { | ||
| if ( '' !== $text_node ) { | ||
| $output .= "{$text_node}\"\n"; | ||
| } | ||
| $was_text = false; | ||
| $text_node = ''; | ||
| } | ||
|
|
||
| switch ( $token_type ) { | ||
| case '#doctype': | ||
| $doctype = $processor->get_doctype_info(); | ||
| $output .= "<!DOCTYPE {$doctype->name}"; | ||
| if ( null !== $doctype->public_identifier || null !== $doctype->system_identifier ) { | ||
| $output .= " \"{$doctype->public_identifier}\" \"{$doctype->system_identifier}\""; | ||
| } | ||
| $output .= ">\n"; | ||
| break; | ||
|
|
||
| case '#tag': | ||
| $namespace = $processor->get_namespace(); | ||
| $tag_name = 'html' === $namespace | ||
| ? strtolower( $processor->get_tag() ) | ||
| : "{$namespace} {$processor->get_qualified_tag_name()}"; | ||
|
|
||
| if ( $is_closer ) { | ||
| --$indent_level; | ||
|
|
||
| if ( 'html' === $namespace && 'TEMPLATE' === $token_name ) { | ||
| --$indent_level; | ||
| } | ||
|
|
||
| break; | ||
| } | ||
|
|
||
| $tag_indent = $indent_level; | ||
|
|
||
| if ( $processor->expects_closer() ) { | ||
| ++$indent_level; | ||
| } | ||
|
|
||
| $output .= str_repeat( $tree_indent, $tag_indent ) . "<{$tag_name}>\n"; | ||
|
|
||
| $attribute_names = $processor->get_attribute_names_with_prefix( '' ); | ||
| if ( $attribute_names ) { | ||
| $sorted_attributes = array(); | ||
| foreach ( $attribute_names as $attribute_name ) { | ||
| $sorted_attributes[ $attribute_name ] = $processor->get_qualified_attribute_name( $attribute_name ); | ||
| } | ||
|
|
||
| /* | ||
| * Sorts attributes to match html5lib sort order. | ||
| * | ||
| * - First comes normal HTML attributes. | ||
| * - Then come adjusted foreign attributes; these have spaces in their names. | ||
| * - Finally come non-adjusted foreign attributes; these have a colon in their names. | ||
| * | ||
| * Example: | ||
| * | ||
| * From: <math xlink:author definitionurl xlink:title xlink:show> | ||
| * Sorted: 'definitionURL', 'xlink show', 'xlink title', 'xlink:author' | ||
| */ | ||
| uasort( | ||
| $sorted_attributes, | ||
| static function ( $a, $b ) { | ||
| $a_has_ns = str_contains( $a, ':' ); | ||
| $b_has_ns = str_contains( $b, ':' ); | ||
|
|
||
| // Attributes with `:` should follow all other attributes. | ||
| if ( $a_has_ns !== $b_has_ns ) { | ||
| return $a_has_ns ? 1 : -1; | ||
| } | ||
|
|
||
| $a_has_sp = str_contains( $a, ' ' ); | ||
| $b_has_sp = str_contains( $b, ' ' ); | ||
|
|
||
| // Attributes with a namespace ' ' should come after those without. | ||
| if ( $a_has_sp !== $b_has_sp ) { | ||
| return $a_has_sp ? 1 : -1; | ||
| } | ||
|
|
||
| return $a <=> $b; | ||
| } | ||
| ); | ||
|
|
||
| foreach ( $sorted_attributes as $attribute_name => $display_name ) { | ||
| $val = $processor->get_attribute( $attribute_name ); | ||
| /* | ||
| * Attributes with no value are `true` with the HTML API, | ||
| * we use the empty string value in the tree structure. | ||
| */ | ||
| if ( true === $val ) { | ||
| $val = ''; | ||
| } elseif ( 'class' === $attribute_name ) { | ||
| $class_names = iterator_to_array( $processor->class_list() ); | ||
| sort( $class_names, SORT_STRING ); | ||
| $val = implode( ' ', $class_names ); | ||
| } elseif ( 'style' === $attribute_name ) { | ||
| $normalized_style = ''; | ||
| foreach ( explode( ';', $val ) as $style ) { | ||
| if ( empty( trim( $style ) ) ) { | ||
| continue; | ||
| } | ||
| list( $style_key, $style_val ) = explode( ':', $style ); | ||
|
|
||
| $style_key = trim( $style_key ); | ||
| $style_val = trim( $style_val ); | ||
|
|
||
| $normalized_style .= "{$style_key}:{$style_val};"; | ||
| } | ||
| $val = $normalized_style; | ||
| } | ||
| $output .= str_repeat( $tree_indent, $tag_indent + 1 ) . "{$display_name}=\"{$val}\"\n"; | ||
| } | ||
| } | ||
|
|
||
| // Self-contained tags contain their inner contents as modifiable text. | ||
| $modifiable_text = $processor->get_modifiable_text(); | ||
| if ( '' !== $modifiable_text ) { | ||
| $output .= str_repeat( $tree_indent, $tag_indent + 1 ) . "\"{$modifiable_text}\"\n"; | ||
| } | ||
|
|
||
| if ( 'html' === $namespace && 'TEMPLATE' === $token_name ) { | ||
| $output .= str_repeat( $tree_indent, $indent_level ) . "content\n"; | ||
| ++$indent_level; | ||
| } | ||
|
|
||
| break; | ||
|
|
||
| case '#cdata-section': | ||
| case '#text': | ||
| $text_content = $processor->get_modifiable_text(); | ||
| if ( '' === trim( $text_content, " \f\t\r\n" ) ) { | ||
| break; | ||
| } | ||
| $was_text = true; | ||
| if ( '' === $text_node ) { | ||
| $text_node .= str_repeat( $tree_indent, $indent_level ) . '"'; | ||
| } | ||
| $text_node .= $text_content; | ||
| break; | ||
|
|
||
| case '#funky-comment': | ||
| // Comments must be "<" then "!-- " then the data then " -->". | ||
| $output .= str_repeat( $tree_indent, $indent_level ) . "<!-- {$processor->get_modifiable_text()} -->\n"; | ||
| break; | ||
|
|
||
| case '#comment': | ||
| // Comments must be "<" then "!--" then the data then "-->". | ||
| $comment = "<!--{$processor->get_full_comment_text()}-->"; | ||
|
|
||
| // Maybe the comment is a block delimiter. | ||
| $parser = new WP_Block_Parser(); | ||
| $parser->document = $comment; | ||
| $parser->offset = 0; | ||
| list( $delimiter_type, $block_name, $block_attrs, $start_offset, $token_length ) = $parser->next_token(); | ||
|
|
||
| switch ( $delimiter_type ) { | ||
| case 'block-opener': | ||
| case 'void-block': | ||
| $output .= str_repeat( $tree_indent, $indent_level ) . "BLOCK[\"{$block_name}\"]\n"; | ||
|
|
||
| if ( 'block-opener' === $delimiter_type ) { | ||
| $block_context[] = $block_name; | ||
| ++$indent_level; | ||
| } | ||
|
|
||
| // If they're no attributes, we're done here. | ||
| if ( empty( $block_attrs ) ) { | ||
| break; | ||
| } | ||
|
|
||
| // Normalize attribute order. | ||
| ksort( $block_attrs, SORT_STRING ); | ||
|
|
||
| if ( isset( $block_attrs['className'] ) ) { | ||
| // Normalize class name order (and de-duplicate), as we need to be tolerant of different orders. | ||
| // (Style attributes don't need this treatment, as they are parsed into a nested array.) | ||
| $block_class_processor = new WP_HTML_Tag_Processor( '<div>' ); | ||
| $block_class_processor->next_token(); | ||
| $block_class_processor->set_attribute( 'class', $block_attrs['className'] ); | ||
| $class_names = iterator_to_array( $block_class_processor->class_list() ); | ||
| sort( $class_names, SORT_STRING ); | ||
| $block_attrs['className'] = implode( ' ', $class_names ); | ||
| } | ||
|
|
||
| $block_attrs = json_encode( $block_attrs, JSON_PRETTY_PRINT ); | ||
| // Fix indentation by "halving" it (2 spaces instead of 4). | ||
| // Additionally, we need to indent each line by the current indentation level. | ||
| $block_attrs = preg_replace( '/^( +)\1/m', str_repeat( $tree_indent, $indent_level ) . '$1', $block_attrs ); | ||
| // Finally, indent the first line, and the last line (with the closing curly brace). | ||
| $output .= str_repeat( $tree_indent, $indent_level ) . substr( $block_attrs, 0, -1 ) . str_repeat( $tree_indent, $indent_level ) . "}\n"; | ||
| break; | ||
| case 'block-closer': | ||
| // Is this a closer for the currently open block? | ||
| if ( ! empty( $block_context ) && end( $block_context ) === $block_name ) { | ||
| // If it's a closer, we don't add it to the output. | ||
| // Instead, we decrease indentation and remove the block from block context stack. | ||
| --$indent_level; | ||
| array_pop( $block_context ); | ||
| } | ||
| break; | ||
| default: // Not a block delimiter. | ||
| $output .= str_repeat( $tree_indent, $indent_level ) . $comment . "\n"; | ||
| break; | ||
| } | ||
| break; | ||
| default: | ||
| // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_var_export | ||
| $serialized_token_type = var_export( $processor->get_token_type(), true ); | ||
| throw new Error( "Unhandled token type for tree construction: {$serialized_token_type}" ); | ||
| } | ||
| } | ||
|
|
||
| if ( null !== $processor->get_unsupported_exception() ) { | ||
| throw $processor->get_unsupported_exception(); | ||
| } | ||
|
|
||
| if ( null !== $processor->get_last_error() ) { | ||
| throw new Error( "Parser error: {$processor->get_last_error()}" ); | ||
| } | ||
|
|
||
| if ( $processor->paused_at_incomplete_token() ) { | ||
| throw new Error( 'Paused at incomplete token.' ); | ||
| } | ||
|
|
||
| if ( '' !== $text_node ) { | ||
| $output .= "{$text_node}\"\n"; | ||
| } | ||
|
|
||
| return $output; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.