Skip to content

Prevent empty author links in Posts list tables #8488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Prevent empty author links in Posts list tables #8488

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1a71d47
Prevent empty author links in Posts list tables
faisal-alvi Mar 11, 2025
adf29b6
update the class name in the doc comment
faisal-alvi Mar 11, 2025
d7d2c85
Small change just to trigger github actions again
audrasjb Mar 11, 2025
8f073b4
Revert previous commit
audrasjb Mar 11, 2025
9f3bc82
Merge branch 'trunk' into pr/8488
joedolson Mar 16, 2025
d956001
Provide message arg in tests with multiple methods
joedolson Mar 16, 2025
51d2faa
Wrap "no author" in parens to match existing strings and test.
joedolson Mar 16, 2025
99c6304
Fetch table from existing setup method.
joedolson Mar 16, 2025
af065bd
Update wpPostsListTable.php
joedolson Mar 16, 2025
8ce46b7
Simplify assertions.
joedolson Mar 16, 2025
e4dee94
This is just to see what's being created.
joedolson Mar 16, 2025
9f2da93
No need to call get_the_author when iterating the post object already.
joedolson Mar 16, 2025
7cadbbc
OK, that doesn't work; revert.
joedolson Mar 16, 2025
6330d89
Update media column_author method to match post tables.
joedolson Mar 16, 2025
0dae4c4
Further simplify assertions.
joedolson Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Provide message arg in tests with multiple methods
  • Loading branch information
@joedolson
joedolson committed Mar 16, 2025
commit d9560014b938309741aede9568c755852e4c1b3b
10 changes: 5 additions & 5 deletions tests/phpunit/tests/admin/wpPostsListTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,8 @@ public function test_column_author_with_valid_author() {
self::$list_table->column_author( $post );
$output = ob_get_clean();

$this->assertStringContainsString( '<a href="' . $expected_url . '">', $output );
$this->assertStringContainsString( '>' . esc_html( $author_name ) . '</a>', $output );
$this->assertStringContainsString( '<a href="' . $expected_url . '">', $output, 'Author column contains author URL' );
$this->assertStringContainsString( '>' . esc_html( $author_name ) . '</a>', $output, 'Author column contains linked author name.' );
}

/**
Expand All @@ -372,8 +372,8 @@ public function test_column_author_with_no_author() {
self::$list_table->column_author( $post );
$output = ob_get_clean();

$this->assertStringContainsString( '<span aria-hidden="true">&#8212;</span>', $output );
$this->assertStringContainsString( '<span class="screen-reader-text">(no author)</span>', $output );
$this->assertStringNotContainsString( '<a href="', $output );
$this->assertStringContainsString( '<span aria-hidden="true">&#8212;</span>', $output, 'Author column with no author shows em dash.' );
$this->assertStringContainsString( '<span class="screen-reader-text">(no author)</span>', $output, 'Author column with no author contains screen reader text.' );
$this->assertStringNotContainsString( '<a href="', $output, 'Author column with no author does not contain link.' );
}
}