Skip to content

Add error message under input field. #8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from
+101 −11
Open

Add error message under input field. #8273

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
99a754d
Add error message under input field.
PARTHVATALIYA Feb 7, 2025
c9572cc
Remove debug code.
PARTHVATALIYA Feb 7, 2025
0203b26
Update error message for screen reader.
PARTHVATALIYA Feb 17, 2025
8543607
Merge branch 'trunk' into pr/8273
joedolson Mar 4, 2025
d2c84ce
Various improvements
joedolson Mar 4, 2025
f651ef6
Support error messages in customizer nav menus.
joedolson Mar 6, 2025
e3f12cc
Fix quotes
joedolson Mar 6, 2025
92ba5de
Match the URL validation from customizer
joedolson Mar 6, 2025
741ed61
Copy validation into pre-add test; change error message.
joedolson Mar 6, 2025
b78dd51
Declare the urlRegex variable.
joedolson Mar 6, 2025
6d470d4
String no longer requires double quoting.
joedolson Mar 6, 2025
eee8783
Omitted comma.
joedolson Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix quotes
  • Loading branch information
@joedolson
joedolson committed Mar 6, 2025
commit e3f12cc164f6b06da1ea9296475b4e3df1ec2ef1
2 changes: 1 addition & 1 deletion src/wp-includes/class-wp-customize-nav-menus.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,7 @@ protected function print_custom_links_available_menu_item() {
<p id="menu-item-name-wrap" class="wp-clearfix">
<label class="howto" for="custom-menu-item-name"><?php _e( 'Link Text' ); ?></label>
<input id="custom-menu-item-name" name="menu-item[-1][menu-item-title]" type="text" class="regular-text menu-item-textbox">
<span id="custom-name-error" class="error-message" style="display: none;"><?php _e( "The link text cannot be empty." ); ?></span>
<span id="custom-name-error" class="error-message" style="display: none;"><?php _e( 'The link text cannot be empty.' ); ?></span>
</p>
<p class="button-controls">
<span class="add-to-menu">
Expand Down
Loading