Skip to content

Trac/43421 #7351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Trac/43421 #7351

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e67221b
Assume capabilities passed to add_role should be granted
ethanclevenger91 Sep 13, 2024
016fe1a
Update spacing
ethanclevenger91 Sep 13, 2024
3a4adec
phpcs fixes
ethanclevenger91 Sep 13, 2024
925c285
Test a mixed array of explicit and implicit capabilities.
ethanclevenger91 Sep 17, 2024
2566498
Merge branch 'WordPress:trunk' into trac/43421
ethanclevenger91 Sep 17, 2024
83a3538
cs cleanup
ethanclevenger91 Sep 17, 2024
7d5d1f7
Merge branch 'trac/43421' of github.com:ethanclevenger91/wordpress-de…
ethanclevenger91 Sep 17, 2024
ccf5d0d
Auto-cs fix.
ethanclevenger91 Sep 17, 2024
e764924
Remove support for mixed format capabilities.
ethanclevenger91 Sep 17, 2024
c284c8b
Excess newlines.
ethanclevenger91 Sep 17, 2024
96a5089
Merge branch 'trunk' into trac/43421
johnbillion Jun 29, 2025
1cc3166
Docs.
johnbillion Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
phpcs fixes
  • Loading branch information
@ethanclevenger91
ethanclevenger91 authored Sep 13, 2024
commit 3a4adec68ed31f7d8a99d01cb6f7e0333ac1f185
4 changes: 2 additions & 2 deletions src/wp-includes/class-wp-roles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,9 @@ public function add_role( $role, $display_name, $capabilities = array() ) {
}

foreach ( $capabilities as $key => $value ) {
if ( !is_bool( $value ) ) {
if ( ! is_bool( $value ) ) {
$capabilities[ $value ] = true;
unset( $capabilities[$key] );
unset( $capabilities[ $key ] );
}
}

Expand Down