Skip to content

Add http status code to errors #7170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
+25 −5
Open

Add http status code to errors #7170

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a0fcdb
Add http status code to errors
devansh016 Aug 9, 2024
cc5126e
Remove Trailing comma's
devansh016 Aug 9, 2024
e607756
Remove Trailing comma's
devansh016 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions src/wp-includes/taxonomy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,7 +2407,11 @@ function wp_insert_term( $term, $taxonomy, $args = array() ) {
global $wpdb;

if ( ! taxonomy_exists( $taxonomy ) ) {
return new WP_Error( 'invalid_taxonomy', __( 'Invalid taxonomy.' ) );
return new WP_Error(
'invalid_taxonomy',
__( 'Invalid taxonomy.' ),
array( 'status' => 400 )
);
}

/**
Expand All @@ -2427,11 +2431,19 @@ function wp_insert_term( $term, $taxonomy, $args = array() ) {
}

if ( is_int( $term ) && 0 === $term ) {
return new WP_Error( 'invalid_term_id', __( 'Invalid term ID.' ) );
return new WP_Error(
'invalid_term_id',
__( 'Invalid term ID.' ),
array( 'status' => 400 )
);
}

if ( '' === trim( $term ) ) {
return new WP_Error( 'empty_term_name', __( 'A name is required for this term.' ) );
return new WP_Error(
'empty_term_name',
__( 'A name is required for this term.' ),
array( 'status' => 400 )
);
}

$defaults = array(
Expand All @@ -2443,7 +2455,11 @@ function wp_insert_term( $term, $taxonomy, $args = array() ) {
$args = wp_parse_args( $args, $defaults );

if ( (int) $args['parent'] > 0 && ! term_exists( (int) $args['parent'] ) ) {
return new WP_Error( 'missing_parent', __( 'Parent term does not exist.' ) );
return new WP_Error(
'missing_parent',
__( 'Parent term does not exist.' ),
array( 'status' => 400 )
);
}

$args['name'] = $term;
Expand All @@ -2461,7 +2477,11 @@ function wp_insert_term( $term, $taxonomy, $args = array() ) {

// Sanitization could clean the name to an empty string that must be checked again.
if ( '' === $name ) {
return new WP_Error( 'invalid_term_name', __( 'Invalid term name.' ) );
return new WP_Error(
'invalid_term_name',
__( 'Invalid term name.' ),
array( 'status' => 400 )
);
}

$slug_provided = ! empty( $args['slug'] );
Expand Down