Skip to content

Add validation to prevent feed names starting with an underscore. #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add validation to prevent feed names starting with an underscore. #6661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: add validation to prevent feed names starting with an underscore.
  • Loading branch information
@snehapatil2001
snehapatil2001 committed May 28, 2024
commit cfffd1bf80c2e75aa548bf0cd000ceea3c476a98
6 changes: 6 additions & 0 deletions src/wp-includes/rewrite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,12 @@ function remove_permastruct( $name ) {
function add_feed( $feedname, $callback ) {
global $wp_rewrite;

// Validate feed name to not start with an underscore.
if ( '_' === substr( $feedname, 0, 1 ) ) {
_doing_it_wrong( __FUNCTION__, __( 'Feed names should not start with an underscore.' ), '6.2.0' );
return false;
}

if ( ! in_array( $feedname, $wp_rewrite->feeds, true ) ) {
$wp_rewrite->feeds[] = $feedname;
}
Expand Down