Skip to content

Fix body content alignment and avoid sticky menu when there is a PHP notice #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix body content alignment and avoid sticky menu when there is a PHP notice #5168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-admin/css/admin-menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ div.wp-menu-image:before {
}

/* Sticky admin menu */
.sticky-menu #adminmenuwrap {
.sticky-menu:not(.php-error) #adminmenuwrap {
position: fixed;
}

Expand Down
13 changes: 13 additions & 0 deletions src/wp-admin/css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@
overflow: visible;
}

/* Additional margin when there is a PHP notice */
.php-error #wpbody-content {
margin-top: 2em;
}

/* inner 2 column liquid layout */

.inner-sidebar {
Expand Down Expand Up @@ -4097,6 +4102,10 @@ img {
padding-top: 0;
}

html.wp-toolbar body.php-error {
padding-top: 46px;
}

.screen-reader-shortcut:focus {
top: 7px;
}
Expand All @@ -4105,6 +4114,10 @@ img {
padding-top: 46px;
}

body.php-error #wpbody {
padding-top: 0px;
}

/* Keep full-width boxes on Edit Post page from causing horizontal scroll */
div#post-body.metabox-holder.columns-1 {
overflow-x: hidden;
Expand Down
8 changes: 8 additions & 0 deletions src/wp-includes/css/admin-bar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,10 @@ html:lang(he-il) .rtl #wpadminbar * {
top: -3px;
}

.php-error #wpadminbar #wp-admin-bar-wp-logo > .ab-item .ab-icon:before {
top: 9px;
}

#wpadminbar .ab-icon,
#wpadminbar .ab-item:before {
padding: 0;
Expand Down Expand Up @@ -1110,6 +1114,10 @@ html:lang(he-il) .rtl #wpadminbar * {
position: static;
box-shadow: none;
}

.php-error #wpadminbar {
position: fixed;
}
}

/* Very narrow screens */
Expand Down