Skip to content

Follow-up 10401 :Add an inline comment why change made #10410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Follow-up 10401 :Add an inline comment why change made #10410

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6bf7b1d
Add an inline comment why change made
mukeshpanchal27 Oct 24, 2025
8c5e9e0
Apply suggestions from code review
mukeshpanchal27 Oct 24, 2025
bda320a
Add test for feed_links_extra with custom post type
mukeshpanchal27 Oct 24, 2025
f22ba8e
Reset global post variable in feedLinksExtra test
mukeshpanchal27 Oct 24, 2025
e6d320c
Fix post global variable assignment in test
mukeshpanchal27 Oct 24, 2025
93fa4f8
Remove test_feed_links_extra_handles_custom_post_type
mukeshpanchal27 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix post global variable assignment in test
  • Loading branch information
@mukeshpanchal27
mukeshpanchal27 authored Oct 24, 2025
commit e6d320c1bd45ac0b8c7a46861aca356f745a7517
2 changes: 1 addition & 1 deletion tests/phpunit/tests/general/feedLinksExtra.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,9 +656,9 @@ public function test_feed_links_extra_handles_custom_post_type() {
'post_title' => 'Test post for custom post type feed links extra',
)
);
$GLOBALS['post'] = null;

$this->go_to( get_permalink( $post_id ) );
$GLOBALS['post'] = null;
$this->assertNotEmpty( get_echo( 'feed_links_extra' ) );
}
}
Loading