Skip to content

Check for existing $metadata['sizes'] to fix PHP warning #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

Check for existing $metadata['sizes'] to fix PHP warning #648

merged 1 commit into from
Feb 13, 2023

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Feb 10, 2023 •
edited by felixarntz
Loading

Summary

Fixes #632

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Feb 10, 2023
@mukeshpanchal27 mukeshpanchal27 added this to the 2.0.0 milestone Feb 10, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review February 10, 2023 05:58
felixarntz
felixarntz approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27!

@felixarntz felixarntz changed the title Check for existing $metadata['sizes'] to fix PHP warnings Check for existing $metadata['sizes'] to fix PHP warning Feb 11, 2023
kt-12
kt-12 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@kt-12 kt-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

@mukeshpanchal27 mukeshpanchal27 merged commit 3e48f93 into trunk Feb 13, 2023
@mukeshpanchal27 mukeshpanchal27 deleted the fix/632-php-warnings branch February 13, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixarntz felixarntz felixarntz approved these changes

@kt-12 kt-12 kt-12 approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@mitogh mitogh Awaiting requested review from mitogh

Assignees

No one assigned

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Check for existing $metadata['sizes'] to reduce PHP warnings

4 participants

@mukeshpanchal27 @felixarntz @kt-12