Skip to content

Optimize computing dominant color and transparency for images by combining the two functions #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 28, 2022
Merged

Optimize computing dominant color and transparency for images by combining the two functions #381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1461b6d
Combined the dominant_color_get_dominant_color() and the dominant_col…
pbearne Jun 16, 2022
d7c2b9d
Combined the dominant_color_get_dominant_color() and the dominant_col…
pbearne Jun 16, 2022
d58f2b4
Combined the dominant_color_get_dominant_color() and the dominant_col…
pbearne Jun 16, 2022
2158a17
Update modules/images/dominant-color/load.php
pbearne Jun 20, 2022
198532c
Force hex to 6 characters
spacedmonkey Jun 22, 2022
a6ab609
Merge branch 'trunk' into INITS-976-Avoid_duplicate_execution_of_sett…
spacedmonkey Jun 22, 2022
37b3222
changed code to return WP_error in has_transparency or dominant_color…
pbearne Jun 24, 2022
b01ba33
Update modules/images/dominant-color/load.php
pbearne Jun 24, 2022
c6f0f2b
Update modules/images/dominant-color/load.php
pbearne Jun 24, 2022
ec6e41a
Update modules/images/dominant-color/load.php
pbearne Jun 24, 2022
57ab283
Update modules/images/dominant-color/load.php
pbearne Jun 24, 2022
43e3dd1
Update modules/images/dominant-color/load.php
pbearne Jun 24, 2022
e4b2e03
Update modules/images/dominant-color/load.php
pbearne Jun 24, 2022
1d2e440
Removed magic code for simpler str_pad function
pbearne Jun 24, 2022
43b5268
Improve unit tests.
spacedmonkey Jun 27, 2022
e75e578
Add get_hex_from_rgb function.
spacedmonkey Jun 27, 2022
83d2cce
Remove test for now.
spacedmonkey Jun 27, 2022
3018d7e
Return wp_error.
spacedmonkey Jun 27, 2022
4e130cb
Change message.
spacedmonkey Jun 27, 2022
043feb2
Check to see if the method exists.
spacedmonkey Jun 27, 2022
879a43f
Improve testing.
spacedmonkey Jun 27, 2022
a9acc67
Ignore on multisite.
spacedmonkey Jun 27, 2022
e5f2054
Change function name.
spacedmonkey Jun 28, 2022
14073b6
Apply suggestions from code review
spacedmonkey Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test for now.
  • Loading branch information
@spacedmonkey
spacedmonkey committed Jun 27, 2022
commit 83d2cce3bc68529cac5661935fbf4fb5267bbfd3
6 changes: 3 additions & 3 deletions modules/images/dominant-color/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,9 +373,9 @@ function dominant_color_has_transparency( $attachment_id ) {
*
* @since n.e.x.t
*
* @param int $red
* @param int $green
* @param int $blue
* @param int $red Red 0-255.
* @param int $green Green 0-255.
* @param int $blue Blue 0-255.
*
* @return string|null Hex color or null if error.
*/
Expand Down
6 changes: 0 additions & 6 deletions tests/utils/TestCase/DominantColorTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,6 @@ public function provider_get_dominant_color() {
'expected_color' => array( '000000' ),
'expected_transparency' => true,
),
'earth_gif' => array(
'image_path' => TESTS_PLUGIN_DIR . '/tests/testdata/modules/images/earth.gif',
'expected_color' => array( '18161a', '1b1a1c', '151517' ),
'expected_transparency' => false,
),

'balloons_webp' => array(
'image_path' => TESTS_PLUGIN_DIR . '/tests/testdata/modules/images/balloons.webp',
'expected_color' => array( 'c1bbb9', 'c3bdbd' ),
Expand Down