-
Notifications
You must be signed in to change notification settings - Fork 140
Replace images in frontend content without using an additional regular expression #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
felixarntz
merged 8 commits into
release/1.0.0-beta.4
from
enhancement/238-image-format-sources
Mar 25, 2022
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
55ca014
Remove the extension check in the webp_uploads_img_tag_update_mime_ty…
eugene-manuilov 6cc3892
Merge remote-tracking branch 'origin/trunk' into enhancement/238-imag…
eugene-manuilov 359f129
Update the webp_uploads_img_tag_update_mime_type function to correctl…
eugene-manuilov 1040980
Update the webp_uploads_img_tag_update_mime_type function not to repl…
eugene-manuilov 2a3f76e
Merge remote-tracking branch 'origin/trunk' into enhancement/238-imag…
eugene-manuilov 401092b
Merge pull request #266 from WordPress/release/1.0.0-beta.4
eugene-manuilov 7263e0b
Merge remote-tracking branch 'origin/trunk' into enhancement/238-imag…
eugene-manuilov 4a96932
Refactor the loop that updates subsizes.
eugene-manuilov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values could be the same. Just thinking out loud here, in terms of PHP performance (I know it's very minor but still worth thinking about) not sure whether that's okay or whether it would be better to use an if check around them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a check to avoid replacing the same images.