-
Notifications
You must be signed in to change notification settings - Fork 140
Allow URL metric schema to be extended #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
a52381d
e244b22
079e6d9
bbc97dc
70fd825
381c829
e85c683
0cc9103
00d57b4
22711e4
384fa53
ed58151
aa1e663
8917ce9
907d8c3
0db296f
ea28aa1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Co-authored-by: Felix Arntz <felixarntz@google.com>
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -348,7 +348,7 @@ protected static function extend_schema_with_optional_properties( array $propert | |
| * @todo Instead of returning null when the key doesn't exist, should the `default` value be returned as defined in the schema? | ||
| * | ||
| * @param string $key Property. | ||
| * @return mixed|null | ||
| * @return mixed|null The property value, or null if not set. | ||
| */ | ||
| public function get( string $key ) { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could make use of generics to specify the expected return type given the input
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe not, as then attempting to access an extended property will result in a PHPStan error. |
||
| return $this->data[ $key ] ?? null; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.