Skip to content

Check if rel contains nofollow instead of being just nofollow when excluding speculative loading #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2024
Merged

Check if rel contains nofollow instead of being just nofollow when excluding speculative loading #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ef38a2
Check rel contains nofollow
tunetheweb May 20, 2024
b415958
Update plugins/speculation-rules/helper.php
tunetheweb May 20, 2024
9f9a4c4
Ser alpha version
tunetheweb May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/speculation-rules/helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ static function ( string $href_exclude_path ) use ( $prefixer ): string {
// Also exclude rel=nofollow links, as plugins like WooCommerce use that on their add-to-cart links.
array(
'not' => array(
'selector_matches' => 'a[rel=nofollow]',
'selector_matches' => 'a[rel~="nofollow"]',
),
),
),
Expand Down
4 changes: 2 additions & 2 deletions plugins/speculation-rules/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Description: Enables browsers to speculatively prerender or prefetch pages when hovering over links.
* Requires at least: 6.4
* Requires PHP: 7.2
* Version: 1.3.0
* Version: 1.3.1-alpha
* Author: WordPress Performance Team
* Author URI: https://make.wordpress.org/performance/
* License: GPLv2 or later
Expand Down Expand Up @@ -65,7 +65,7 @@ static function ( string $global_var_name, string $version, Closure $load ): voi
}
)(
'plsr_pending_plugin_info',
'1.3.0',
'1.3.1-alpha',
static function ( string $version ): void {

// Define the constant.
Expand Down