Skip to content

Fix: Stretchy text issue when nested on flex containers. #73652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
+14 −3
Open

Fix: Stretchy text issue when nested on flex containers. #73652

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0c55bd
Fix: Stretchy text issue when nested on flex containers.
jorgefilipecosta Nov 28, 2025
88f4dbc
handle undefined cases
jorgefilipecosta Nov 28, 2025
dfefb39
minor code improvement
jorgefilipecosta Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/block-editor/src/utils/fit-text-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ function findOptimalFontSize( textElement, applyFontSize ) {
const range = document.createRange();
range.selectNodeContents( textElement );

let referenceElement = textElement;
const parentElement = textElement.parentElement;
if (
parentElement &&
window?.getComputedStyle( parentElement )?.display === 'flex'
) {
referenceElement = parentElement;
}

while ( minSize <= maxSize ) {
const midSize = Math.floor( ( minSize + maxSize ) / 2 );
applyFontSize( midSize );
Expand All @@ -36,12 +45,14 @@ function findOptimalFontSize( textElement, applyFontSize ) {
// Check if text fits within the element's width and is not
// overflowing into the padding area.
const fitsWidth =
textElement.scrollWidth <= textElement.clientWidth &&
textWidth <= textElement.clientWidth - paddingLeft - paddingRight;
textElement.scrollWidth <= referenceElement.clientWidth &&
// textWidth <= textElement.parentElement.clientWidth &&
textWidth <=
referenceElement.clientWidth - paddingLeft - paddingRight;
// Check if text fits within the element's height.
const fitsHeight =
alreadyHasScrollableHeight ||
textElement.scrollHeight <= textElement.clientHeight;
textElement.scrollHeight <= referenceElement.clientHeight;

if ( fitsWidth && fitsHeight ) {
bestSize = midSize;
Expand Down
Loading