Skip to content

Try adding generic entity search component with combobox component #73469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: trunk
Choose a base branch
from
Draft

Try adding generic entity search component with combobox component #73469

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
901ef36
Attempt to use combobox with entity searching
jeryj Nov 20, 2025
8e3c0a5
Allow entity binding from combobox
jeryj Nov 20, 2025
25b8b54
Add current value as first option when clicking into combobox
jeryj Nov 20, 2025
f202200
Handle focus management
jeryj Nov 20, 2025
29d9e3e
Fix debounce clearing value if tab off quickly:
jeryj Nov 20, 2025
0e19320
Use default component styles
jeryj Nov 21, 2025
aafb6d2
Have same expandOnFocus behavior for click and tab for combobobx control
jeryj Nov 21, 2025
e4aaba5
Extract API to pass in the query instead of having entitysearch build it
jeryj Nov 21, 2025
910bf1c
Fix freeform value not adding until after debounce
jeryj Nov 21, 2025
df1fb29
Search by block entity
jeryj Nov 21, 2025
abd0132
Fix styling
jeryj Nov 21, 2025
ccd8c06
Fix missing label on link input. Only search if 2 or more chars
jeryj Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix missing label on link input. Only search if 2 or more chars
  • Loading branch information
@jeryj
jeryj committed Nov 21, 2025
commit ccd8c06e53117aac2b3d7860dc18a5a27e181ab5
7 changes: 6 additions & 1 deletion packages/block-editor/src/components/entity-search/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,12 @@ export const EntitySearch = forwardRef(
return;
}

// Only search if term is empty (initial suggestions) or has 2+ characters
if ( term.length === 1 ) {
// Don't search with single character, keep showing previous results
return;
}

setIsLoading( true );
onSearch( term )
.then( ( results ) => {
Expand Down Expand Up @@ -275,7 +281,6 @@ export const EntitySearch = forwardRef(
}
} }
isLoading={ isLoading }
hideLabelFromVision
expandOnFocus={ false }
placeholder={ __( 'Search or type URL' ) }
__experimentalRenderItem={ ( { item } ) => {
Expand Down
Loading