Skip to content

Dataforms: Add pattern validation. #73156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 21, 2025
Merged

Dataforms: Add pattern validation. #73156

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
305bc10
initial pattern validation version
jorgefilipecosta Nov 11, 2025
7ff8fe8
simplify some storybook regex
jorgefilipecosta Nov 11, 2025
898503d
remove pattern from textarea it is not supported
jorgefilipecosta Nov 11, 2025
e534d9d
remove leftover from textarea try
jorgefilipecosta Nov 11, 2025
a7967ca
lint fix
jorgefilipecosta Nov 11, 2025
bdc0011
Update storybook single story per field
jorgefilipecosta Nov 17, 2025
38f62aa
remove unrequired code
jorgefilipecosta Nov 19, 2025
72424ed
force pattern to be a string
jorgefilipecosta Nov 19, 2025
df2481d
update storybook patterns to be strings
jorgefilipecosta Nov 19, 2025
a9cef37
add changelog
jorgefilipecosta Nov 19, 2025
18f035e
add pattern validation to useFormValidity hook
jorgefilipecosta Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify some storybook regex
  • Loading branch information
@jorgefilipecosta
jorgefilipecosta committed Nov 21, 2025
commit 7ff8fe8721b44f98c5efb27676857ff8051eeb46
4 changes: 2 additions & 2 deletions packages/dataviews/src/stories/dataform.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ const ValidationComponent = ( {
description: 'Email must be from @company.com domain',
isValid: {
required,
pattern: /^[a-zA-Z0-9._%+-]+@company\.com$/,
pattern: /^[a-zA-Z0-9]+@company\.com$/,
},
},
{
Expand Down Expand Up @@ -1077,7 +1077,7 @@ const ValidationComponent = ( {
description: 'Must be a GitHub repository URL',
isValid: {
required,
pattern: /^https:\/\/github\.com\/[\w-]+\/[\w-]+\/?$/,
pattern: /^https:\/\/github\.com\/.*/,
},
},
{
Expand Down