Skip to content

Perf: Only mount SpacingVisualizers when actively visualizing #72800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
+34 −18
Merged

Perf: Only mount SpacingVisualizers when actively visualizing #72800

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a16d114
Don't subscribe dimensions panel to store if it's disabled
jeryj Oct 21, 2025
fd1560a
Perf: Only mount SpacingVisualizers when actively visualizing
jeryj Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't subscribe dimensions panel to store if it's disabled
  • Loading branch information
@jeryj
jeryj committed Nov 5, 2025
commit a16d114014f70c0e037277772caa39db37883a08
12 changes: 9 additions & 3 deletions packages/block-editor/src/hooks/dimensions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,15 @@ function DimensionsInspectorControl( { children, resetAllFilter } ) {
export function DimensionsPanel( { clientId, name, setAttributes, settings } ) {
const isEnabled = useHasDimensionsPanel( settings );
const value = useSelect(
( select ) =>
select( blockEditorStore ).getBlockAttributes( clientId )?.style,
[ clientId ]
( select ) => {
// Early return to avoid subscription when disabled
if ( ! isEnabled ) {
return undefined;
}
return select( blockEditorStore ).getBlockAttributes( clientId )
?.style;
},
[ clientId, isEnabled ]
);
const [ visualizedProperty, setVisualizedProperty ] = useVisualizer();
const onChange = ( newStyle ) => {
Expand Down